[DevSpec] Updates to input validation spec - #4190
Merged
almedina-ms merged 64 commits intoJun 29, 2020
Merged
Conversation
Updated the "Start the documentation site" heading to be at the same level as the rest of the headings
[UWP] Fix null dereference in Media code path
…ue with WholeItemsPanel (#3710)
* updated the doc * Updated specs * updated the description * Updated specs * updated the doc to correct wrong info * Updated specs
1. Including PreRequisite section around repo bootstrap linking to root readme 2. Cleaning up build commands to use lerna to be consistent with root readme and removing redundant steps
Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
* [UWP] Remove image comparison from unit tests * Code review feedback
* Added MaxActions limit check and replaced multiple of GetActions() call That returns a structure by value * added UnitTesting and Warning * added UnitTesting and Warning fixed comments Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
* updating telephony detection for markdown link * undo uneccesary changes * updated RichTextBlockRenderer to detect Telephony link * updated sample card Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
* Fix scrolling behaviour in multiline text input * Add test files Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
* [SharedModel] Skip date/time tests outside of Pacific TZ Fixes #3609 * Rename TEST_MODULE_INITIALIZE method * Remove TEST_MODULE_INITIALIZE altogether * Update macro name Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
New HostConfig for Cortana Windows UWP beta, light mode. To be added to the drop down as: Cortana (Beta) - Light
Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com>
* Fix to have short time format * Change helper function * Add unit tets * Add sample test json * Remove unnecessary test file
* Updated Cover FillMode Behavior * Revew Comments Addresssed * adding testing card * Updated file
* Updated preprocessed text handling * updated formatting * Added Accesibility Tags * updated accessibility Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
* Updated iOS layout * removed wrapper on TextBlock and RichTextBlock renderers * updated layout views to use intrinsic contentsize * updated property value for layout vies * Added key value observation for hidden property to allow toggle visibility and the new layout change to work together * Updated views with toggle visibility to update its contentsize based on their visibility changes Updated padding priority for bleeding * restores to working project file * updated project file for xcode * updated for CR comments * Fixed for CR comments Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
RebeccaAnne
reviewed
Jun 22, 2020
| ### Option 2 – LabelFor Property on TextBlocks/RichTextBlocks | ||
| An alternative option would be to have labels as separate text elements, but provide an id that links the inputs to the labels: | ||
| ``` json | ||
| Both of the afore mentioned cards would produce the same rendered result that would look like this: |
Contributor
There was a problem hiding this comment.
afore mentioned [](start = 12, length = 15)
[nit] aforementioned
RebeccaAnne
reviewed
Jun 22, 2020
| "placeholder": "Last, First" | ||
| "requires": { | ||
| "inputLabels": "1.0" | ||
| } |
Contributor
There was a problem hiding this comment.
Has there been any further discussion/decision around whether we want to do this? If we're not planning to, we should probably say that here or remove this idea from the spec.
RebeccaAnne
reviewed
Jun 22, 2020
| "version": "1.3" | ||
| }, | ||
| "label": { | ||
| "type": "string|TextBlock|RichTextBlock", |
Contributor
There was a problem hiding this comment.
|TextBlock|RichTextBlock [](start = 18, length = 24)
If we're not supporting this for v1 we should remove these from here. In general we should make sure the schema files are up-to-date with the latest spec changes.
RebeccaAnne
reviewed
Jun 22, 2020
|
|
||
| ### Host side styling | ||
|
|
||
| As has been proposed, the error message is a string property which is rendered in the `attention` color by default, card hosts may need more control over how this messages and the visual representation of an error appear. As can be seen in the [Annex] there's a wide array on how error messages are represented in different websites. The table below details the proposed set of properties that host apps will be able to modify based on the examples located in the annex as well as if they are going to be modified through the host config or the native styling in each platform. It's important to note that some of this properties will act on the input element rather than the error message. |
Contributor
There was a problem hiding this comment.
[Annex] [](start = 244, length = 7)
Link?
RebeccaAnne
reviewed
Jun 22, 2020
|
|
||
| ### Host side styling | ||
|
|
||
| As has been proposed, the error message is a string property which is rendered in the `attention` color by default, card hosts may need more control over how this messages and the visual representation of an error appear. As can be seen in the [Annex] there's a wide array on how error messages are represented in different websites. The table below details the proposed set of properties that host apps will be able to modify based on the examples located in the annex as well as if they are going to be modified through the host config or the native styling in each platform. It's important to note that some of this properties will act on the input element rather than the error message. |
Contributor
There was a problem hiding this comment.
It's important to note that some of this properties will act on the input element rather than the error message. [](start = 578, length = 112)
Can you clarify this a bit? I assume "size" and "weight" do refer to the error message and that "spacing" refers to the space between the input and the error? Might make sense to explicitly call out what these properties do.
RebeccaAnne
reviewed
Jun 22, 2020
| This conflict speaks to a general tension inherent in the design of Adaptive Cards. There's always going to be a trade off between giving the author more power, and letting the host control the experience for their users. We need to determine what balance we want to strike in this case. | ||
|
|
||
| We should also consider which item types are valid as labels. Probably just TextBlock and RichTextBlock make sense, but as Xaml supports other types we should consider whether we want to as well. | ||
| In order to gather more data to help us balance the needs of the card authors and hosts, we sent a survey to customers who have expressed an interest in improving out input story. The survey sent included 10 questions including the topics of input validation and input labels, for this spec we will only review the 4 questions that focus on the former topic. The results for this questions were used to leverage on some of the decisions taken on this spec document and can be found in the [Appendix](Appendix). |
Contributor
There was a problem hiding this comment.
for this spec we will only review the 4 questions that focus on the former topic [](start = 277, length = 80)
Thanks for this detailed discussion of how the survey results were used! Great to see this feedback in action.
RebeccaAnne
reviewed
Jun 22, 2020
|
|
||
| #### UWP (XAML) | ||
|
|
||
| For the UWP renderer we can still support the current styles that host apps have defined for their inputs, we would only have to provide the naming convention for the visual states for valid (or neutral) and invalid inputs. The following snippet should provide a template on how hosts could specify this custom rendering by overloading the `InvalidState` on the VisualStateGroup: |
Contributor
There was a problem hiding this comment.
For the UWP renderer we can still support the current styles that host apps have defined for their inputs [](start = 0, length = 105)
This is cool. Is this implemented already?
RebeccaAnne
reviewed
Jun 24, 2020
| * If the `Submit` action on card B is clicked, then inputs in card A and card B are retrieved, but not the inputs in card C | ||
| * If the `Submit` action on card C is clicked, then inputs in card A and card C are retrieved, but not the inputs in card B | ||
|
|
||
| To summarize, all the inputs in the card where the `Submit` action was clicked and all the inputs in all the "parent" cards are retrieved, no inputs in "sibling" cards are retrieved. In the diagram above, card A would be a "parent" of B and C, and card B and C are siblings. |
Contributor
There was a problem hiding this comment.
To summarize [](start = 0, length = 12)
What happens in a scenario where an input is hidden behind a toggle action? Are those retrieved regardless of whether or not they are hidden?
RebeccaAnne
reviewed
Jun 24, 2020
|
|
||
| - If "All" doesn't work well for a particular card, allowing the card author to explicitly specify inputs allows them to override this default behavior to configure the validation as appropriate for their scenario. | ||
|
|
||
| ##### Conclusion |
Contributor
There was a problem hiding this comment.
This conclusion section doesn't have a link in the table of contents
RebeccaAnne
reviewed
Jun 24, 2020
|
|
||
| > Note on this card: This "Wizard" scenario is implemented here via toggle visibility. We should consider whether we want to support a first class wizard experience where a new element type could list a series of subcards to display in order. Whether or not we ever introduce such a concept, the point remains that toggle logic may be complex, and we shouldn't be arbitrarily toggling things visible outside the scope of what the card author has defined in their toggle buttons. | ||
|
|
||
| #### Current Card/Container |
Contributor
There was a problem hiding this comment.
This is effectively the approach you land on at the end, so maybe combine, reorganize, or mention that here. Also, this section brings up concerns with this approach that aren't addressed in the conclusion, so we should probably add something around how we're addressing them and/or why they're less pressing than other considerations.
RebeccaAnne
reviewed
Jun 24, 2020
| | `Input.ChoiceSet` | `isRequired` | Any value has been selected. In the case of multiselect, 1 or more values have been selected. | | ||
| | `Input.Toggle` | `isRequired` | ValueOn has been selected. | | ||
|
|
||
| ### Which Inputs to Validate |
Contributor
There was a problem hiding this comment.
Which Inputs to Validate [](start = 4, length = 24)
I think this section is a little unwieldy now, and honestly it probably was already when i handed it off. Consider reorganizing this to put what we're actually shipping up front, and maybe move some of the detailed discussion of other options to the appendix and reference them from the text. Ideally someone would be able to come to this document in the future and easily see what the expected behavior is. We don't want to lose the discussion of tradeoffs, but now that we've decided on something we should probably lead with that.
Also, because we both added to this at different times and with different opinions, i feel like it's maybe not super consistent about it's message on the tradeoffs of the various approaches (a section i wrote says one way is the best, and a section you wrote says something else). Consider re-reading through the whole section and seeing if there are places where we should update the language to present a consistent point of view. Again, we don't want to lose the substance of the discussions/disagreements, but someone reading should be able to come away from it with a clear feeling that "The team decided X approach was best for Y reasons."
ghost
added
the
|
Hi @almedina-ms. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
@RebeccaAnne could you work @almedina-ms to get this merged into the topic branch? Thanks! |
|
Hi @shalinijoshi19; Thanks for commenting on this previously stale pull request. Resetting staleness. @almedina-ms FYI. |
…InputValidationSpec2
shalinijoshi19
pushed a commit
that referenced
this pull request
Jul 22, 2020
* Add classes for validation * Add interfaces for input validation * [UWP] Input Validation Prototype * Second version of validation * Update some stuff * Add minor fixes and ur * Add multitype label support * Fix break * Add support for card elements as labels * Add automation properties * Add fixes for accessibiloty * Add host config support * Fix accessibility for error messages * Add host config options for validation behavior * Modify host config to show enw options * Add files to project * Remove UWP specific code * Remove Android specific code changes * Update test files * [TS] Input validation (#4197) * Work in progress * Code complete * Now actually code complete * Fix not all required inputs gathered from ShowCard * Accessibility support * Add aria-required, hide suffix from accessibility * aria-required for Toggle and ChoiceSet * Add sample Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [Shared model] Update namings in host config (#4213) * Remove validation behaviour from host config * Update namings in hostconfig * Fix build errors * Fix some test json for bugbash * Fix cards with errors * Update long labels to be loooooooooooooooooooooong * [DevSpec] Updates to input validation spec (#4190) * Input Validation Spec Documents * Fix casing on broken image links' * Updates to document based on discussions and feedback * Minor formatting change Updated the "Start the documentation site" heading to be at the same level as the rest of the headings * Removing instructions around explicit hexo install * [Security] Bump handlebars in /source/nodejs/adaptivecards (#3692) * Bump handlebars from 4.1.2 to 4.5.3 in /source/community/reactnative (#3694) * [UWP] Fix null dereference in Media code path (#3669) [UWP] Fix null dereference in Media code path * [UWP] Fix RendererRegistration error handling and fix inheritance issue with WholeItemsPanel (#3710) * updated the doc (#3706) * updated the doc * Updated specs * updated the description * Updated specs * updated the doc to correct wrong info * Updated specs * [Accessibility] Fixing some color contrast issues in the website (#3698) * Updating adaptivecards.io homepage's roadmap links to point to the updated productboard portal * Fixes #3577 ; Fixes #3576: * Fixing outlook.css since that is the style sheet that is being picked up by default when you hit the explorer page * automatic package.json changes * Fixing color syntax * Site readme updates (#3699) 1. Including PreRequisite section around repo bootstrap linking to root readme 2. Cleaning up build commands to use lerna to be consistent with root readme and removing redundant steps * added test to parse and render all sample cards (#3679) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [UWP] Remove image comparison from unit tests (#3724) * [UWP] Remove image comparison from unit tests * Code review feedback * Added MaxActions Limit Check (#3696) * Added MaxActions limit check and replaced multiple of GetActions() call That returns a structure by value * added UnitTesting and Warning * added UnitTesting and Warning fixed comments Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Jwoo/ios telephony update (#3680) * updating telephony detection for markdown link * undo uneccesary changes * updated RichTextBlockRenderer to detect Telephony link * updated sample card Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Fix scrolling behaviour in multiline Input.Text (#3714) * Fix scrolling behaviour in multiline text input * Add test files Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix vertical content alignment for elements in root (#3716) * [SharedModel] Skip date/time tests outside of Pacific TZ (#3611) * [SharedModel] Skip date/time tests outside of Pacific TZ Fixes #3609 * Rename TEST_MODULE_INITIALIZE method * Remove TEST_MODULE_INITIALIZE altogether * Update macro name Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Create cortana-beta-light.json (#3729) New HostConfig for Cortana Windows UWP beta, light mode. To be added to the drop down as: Cortana (Beta) - Light * Create cortana-beta-dark.json (#3730) Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> * [Android] Fix to have HH:mm in Input.Time elements (#3713) * Fix to have short time format * Change helper function * Add unit tets * Add sample test json * Remove unnecessary test file * Fixed #3741 (#3743) * Updated Cover FillMode Behavior (#3725) * Updated Cover FillMode Behavior * Revew Comments Addresssed * adding testing card * Updated file * Updated Handling of Preprocessed Text (#3727) * Updated preprocessed text handling * updated formatting * Added Accesibility Tags * updated accessibility Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * updated project file to expose media rendere (#3726) * iOS new layout scheme (#3687) * Updated iOS layout * removed wrapper on TextBlock and RichTextBlock renderers * updated layout views to use intrinsic contentsize * updated property value for layout vies * Added key value observation for hidden property to allow toggle visibility and the new layout change to work together * Updated views with toggle visibility to update its contentsize based on their visibility changes Updated padding priority for bleeding * restores to working project file * updated project file for xcode * updated for CR comments * Fixed for CR comments Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * updated the gradle property to handle error token (#3742) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * More feedback updates * Add backwards compatibility section * Update to labels spec to reflect the latest discussions * Add an update to the label spec to cover the current state of discussions * Update some open discussion and comments * Update link * Flesh out host config options * Fix some comments * Fix more comments * Split original spec into two options * Fix comment from discussion * Get the general spec on track with the other two * Add almost final version * Move costing outside of appendix * Add index to point to topics easier * Add table of contents for validation * Add WCA Guidelines * Add requirements * Update specs * Remove markdown from v1 * Make small updates to input validation spec * Add fixes for comments from last meeting * Update host config structure * Take options out of scope for associated inputs * Add changes from 05/26 meeting * Update requirements * Update last details of spec * [Android] Show all ActionSet's in column (#4181) * Adjust ActionSet container height to fit contents * Add test card * Fix UWP build break after branch change and merge * Revert no longer relevent changes in samples and schema Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: jarusse <59999260+jarusse@users.noreply.github.com> Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> * [UWP] Input Evolution (#4088) * Re add everything related to UWP * Remove validation behaviour from host config * Remove references to validation behaviour * Update input retrieval * Add changes to respect label and error messages on custom inputs * Remove comment and repeated code * Update namings in hostconfig * Update host config and fixes broken error message setting * Fix first batch of comments in PR * Remove render context from input value constructor * Fix more comments from PR * Fix more comments * Fix text wrapping in error message and bug in time input validation * Fix input retrieval bug Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Input labels and errors support (#4039) * First working android version for inputs and errors * Clean up android tests * Fix tests for other input types * Update swig files * Fix build error * Remove validation behaviour from host config * Remove validation behaviour references * Working version n1 for visible views only * Add more changes to respect basic properties as spacing * Add fix to compress casting tasks * Fix some behaviours and check that all inputs work * Update host config * Updsate object model file * Readd legacy card import for testing purposes * Fix android not rendering elements * Fix issues found in bug bash' * Fix test fieks * Fix tests Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix casting issue * Add missing file from previous commit * [WPF] Input Evolution (#4172) * Add NET shared model support and WPF rendering support for labels and error messages * Fix validation bugs * Fix some acessibility issues Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [UWP] Fix inline actions not getting inputs (#4266) * Fix inline actions not validating inputs * Updated specs Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com> * [UWP] Respect host config formatting for labels (#4289) * Fix host config on labels * Fix comments * Fix crashes when no input exist in a card (#4316) * [UWP] Sample custom input (#4282) * Add sample input and changes the use of internal id for string id * Fix commments from PR * [WPF] Rename the input label host config property to match cpp shared model (#4308) * Rename the input label host config properties * Remove build files from git * Remove invalid test cards and add new valid test cards * Remove associated inputs from submit actions * Fix failing tests * Fix test errors * Rename custom input to be the same as other renderers (#4328) * Fix input visibility (#4306) * Fix crash when clicking inline actin (#4290) * Fix samples (#4347) * Remove build files from git * Add properties to hostconfig and fix duplicated id Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [TS] Input accessibility + designer open sample dialog fixes (#4239) * [JS] Input accessibility and designer fixes * Fix Input.Number min/max not honored when set to 0 * Update package-lock.json * Further package-lock.json updates Co-authored-by: Paul Campbell (DEP) <paulcam@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Ts/input label as label (#4354) * [JS] Input label as <label> * Fix typo * Update package-lock.json * Another package-lock update * Small preview mode fix Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [Android] fix focus on elements (#4321) * Add custom input element to verify correct label rendering * Fix Focus Visibility on choiceset elements * Add missing file change * Fix build error Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * work in progress * completed input view * completed input label & work in progress for inputvalidation * [UWP] Fix crash when invoking show cards (#4370) * Remove control validation (#4379) * [Android] Fix suffix rendering in labels (#4372) * Remove build files from git * Fix label suffix * [Android] Fix visual input cue to clean the state on instantiation (#4373) * Remove build files from git * Fix preloaded visual cue * [Android] Fix empty date input (#4374) * Remove build files from git * Fix date input to allow being empty on start * complted implementing input validation * [JS] Regenerate package-lock files * code complete * Revert "Merge branch 'jwoo/ios-input-evolution' into feature/inputEvolution" This reverts commit dda9109, reversing changes made to 609f25e. * Emit warning for required inputs without label (#4435) * [UWP] Fix Input.Number validation logic to ensure value is a number (#4432) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [WPF] Fix automation properties (#4371) * Remove build files from git * Fix AutomationProperties for Accessibility * Fix comments from pr Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add warnings for empty labels in required inputs (#4409) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add warning for empty label in required input (#4454) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add input retrieval to inlinr submit actions (#4453) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Fix stretch textblock claiming all visible space (#4452) * Fix elements taking the whole space * Add sample files Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Sample updates (#4455) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Change choiceset returns from null to empty (#4458) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * ios input evolution (#4437) * refactored and fixed bug bash bugs * fixed merge error * added warning messages when there is no error message is present when the input has the validations * refactored code and fixed unit tests * updated failed test card since bad card is fixed Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix label to make hint always have attention color (#4456) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fixing .NET CI tests for feature/inputEvolution (#4462) * Ignoring default value for LabelConfig.inputspacing during serialization * Updating API doc * Fixing regression in WPF renderer processing v1.0 inputs * Reverting changes to default launchSettings for the ImageRenderer sample Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: David Claux <dclaux@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: jarusse <59999260+jarusse@users.noreply.github.com> Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com>
almedina-ms
added a commit
that referenced
this pull request
Sep 21, 2020
* Add classes for validation * Add interfaces for input validation * [UWP] Input Validation Prototype * Second version of validation * Update some stuff * Add minor fixes and ur * Add multitype label support * Fix break * Add support for card elements as labels * Add automation properties * Add fixes for accessibiloty * Add host config support * Fix accessibility for error messages * Add host config options for validation behavior * Modify host config to show enw options * Add files to project * Remove UWP specific code * Remove Android specific code changes * Update test files * [TS] Input validation (#4197) * Work in progress * Code complete * Now actually code complete * Fix not all required inputs gathered from ShowCard * Accessibility support * Add aria-required, hide suffix from accessibility * aria-required for Toggle and ChoiceSet * Add sample Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [Shared model] Update namings in host config (#4213) * Remove validation behaviour from host config * Update namings in hostconfig * Fix build errors * Fix some test json for bugbash * Fix cards with errors * Update long labels to be loooooooooooooooooooooong * [DevSpec] Updates to input validation spec (#4190) * Input Validation Spec Documents * Fix casing on broken image links' * Updates to document based on discussions and feedback * Minor formatting change Updated the "Start the documentation site" heading to be at the same level as the rest of the headings * Removing instructions around explicit hexo install * [Security] Bump handlebars in /source/nodejs/adaptivecards (#3692) * Bump handlebars from 4.1.2 to 4.5.3 in /source/community/reactnative (#3694) * [UWP] Fix null dereference in Media code path (#3669) [UWP] Fix null dereference in Media code path * [UWP] Fix RendererRegistration error handling and fix inheritance issue with WholeItemsPanel (#3710) * updated the doc (#3706) * updated the doc * Updated specs * updated the description * Updated specs * updated the doc to correct wrong info * Updated specs * [Accessibility] Fixing some color contrast issues in the website (#3698) * Updating adaptivecards.io homepage's roadmap links to point to the updated productboard portal * Fixes #3577 ; Fixes #3576: * Fixing outlook.css since that is the style sheet that is being picked up by default when you hit the explorer page * automatic package.json changes * Fixing color syntax * Site readme updates (#3699) 1. Including PreRequisite section around repo bootstrap linking to root readme 2. Cleaning up build commands to use lerna to be consistent with root readme and removing redundant steps * added test to parse and render all sample cards (#3679) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [UWP] Remove image comparison from unit tests (#3724) * [UWP] Remove image comparison from unit tests * Code review feedback * Added MaxActions Limit Check (#3696) * Added MaxActions limit check and replaced multiple of GetActions() call That returns a structure by value * added UnitTesting and Warning * added UnitTesting and Warning fixed comments Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Jwoo/ios telephony update (#3680) * updating telephony detection for markdown link * undo uneccesary changes * updated RichTextBlockRenderer to detect Telephony link * updated sample card Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Fix scrolling behaviour in multiline Input.Text (#3714) * Fix scrolling behaviour in multiline text input * Add test files Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix vertical content alignment for elements in root (#3716) * [SharedModel] Skip date/time tests outside of Pacific TZ (#3611) * [SharedModel] Skip date/time tests outside of Pacific TZ Fixes #3609 * Rename TEST_MODULE_INITIALIZE method * Remove TEST_MODULE_INITIALIZE altogether * Update macro name Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Create cortana-beta-light.json (#3729) New HostConfig for Cortana Windows UWP beta, light mode. To be added to the drop down as: Cortana (Beta) - Light * Create cortana-beta-dark.json (#3730) Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> * [Android] Fix to have HH:mm in Input.Time elements (#3713) * Fix to have short time format * Change helper function * Add unit tets * Add sample test json * Remove unnecessary test file * Fixed #3741 (#3743) * Updated Cover FillMode Behavior (#3725) * Updated Cover FillMode Behavior * Revew Comments Addresssed * adding testing card * Updated file * Updated Handling of Preprocessed Text (#3727) * Updated preprocessed text handling * updated formatting * Added Accesibility Tags * updated accessibility Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * updated project file to expose media rendere (#3726) * iOS new layout scheme (#3687) * Updated iOS layout * removed wrapper on TextBlock and RichTextBlock renderers * updated layout views to use intrinsic contentsize * updated property value for layout vies * Added key value observation for hidden property to allow toggle visibility and the new layout change to work together * Updated views with toggle visibility to update its contentsize based on their visibility changes Updated padding priority for bleeding * restores to working project file * updated project file for xcode * updated for CR comments * Fixed for CR comments Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * updated the gradle property to handle error token (#3742) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * More feedback updates * Add backwards compatibility section * Update to labels spec to reflect the latest discussions * Add an update to the label spec to cover the current state of discussions * Update some open discussion and comments * Update link * Flesh out host config options * Fix some comments * Fix more comments * Split original spec into two options * Fix comment from discussion * Get the general spec on track with the other two * Add almost final version * Move costing outside of appendix * Add index to point to topics easier * Add table of contents for validation * Add WCA Guidelines * Add requirements * Update specs * Remove markdown from v1 * Make small updates to input validation spec * Add fixes for comments from last meeting * Update host config structure * Take options out of scope for associated inputs * Add changes from 05/26 meeting * Update requirements * Update last details of spec * [Android] Show all ActionSet's in column (#4181) * Adjust ActionSet container height to fit contents * Add test card * Fix UWP build break after branch change and merge * Revert no longer relevent changes in samples and schema Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: jarusse <59999260+jarusse@users.noreply.github.com> Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> * [UWP] Input Evolution (#4088) * Re add everything related to UWP * Remove validation behaviour from host config * Remove references to validation behaviour * Update input retrieval * Add changes to respect label and error messages on custom inputs * Remove comment and repeated code * Update namings in hostconfig * Update host config and fixes broken error message setting * Fix first batch of comments in PR * Remove render context from input value constructor * Fix more comments from PR * Fix more comments * Fix text wrapping in error message and bug in time input validation * Fix input retrieval bug Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Input labels and errors support (#4039) * First working android version for inputs and errors * Clean up android tests * Fix tests for other input types * Update swig files * Fix build error * Remove validation behaviour from host config * Remove validation behaviour references * Working version n1 for visible views only * Add more changes to respect basic properties as spacing * Add fix to compress casting tasks * Fix some behaviours and check that all inputs work * Update host config * Updsate object model file * Readd legacy card import for testing purposes * Fix android not rendering elements * Fix issues found in bug bash' * Fix test fieks * Fix tests Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix casting issue * Add missing file from previous commit * [WPF] Input Evolution (#4172) * Add NET shared model support and WPF rendering support for labels and error messages * Fix validation bugs * Fix some acessibility issues Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [UWP] Fix inline actions not getting inputs (#4266) * Fix inline actions not validating inputs * Updated specs Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com> * [UWP] Respect host config formatting for labels (#4289) * Fix host config on labels * Fix comments * Add custom input element to verify correct label rendering * Fix crashes when no input exist in a card (#4316) * [UWP] Sample custom input (#4282) * Add sample input and changes the use of internal id for string id * Fix commments from PR * [WPF] Rename the input label host config property to match cpp shared model (#4308) * Rename the input label host config properties * Remove build files from git * Remove invalid test cards and add new valid test cards * Remove associated inputs from submit actions * Fix failing tests * Fix test errors * Rename custom input to be the same as other renderers (#4328) * Fix input visibility (#4306) * Fix crash when clicking inline actin (#4290) * Fix samples (#4347) * Remove build files from git * Add properties to hostconfig and fix duplicated id Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [TS] Input accessibility + designer open sample dialog fixes (#4239) * [JS] Input accessibility and designer fixes * Fix Input.Number min/max not honored when set to 0 * Update package-lock.json * Further package-lock.json updates Co-authored-by: Paul Campbell (DEP) <paulcam@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Change async operations to work on a concurrent manner (#4346) * Ts/input label as label (#4354) * [JS] Input label as <label> * Fix typo * Update package-lock.json * Another package-lock update * Small preview mode fix Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [Android] fix focus on elements (#4321) * Add custom input element to verify correct label rendering * Fix Focus Visibility on choiceset elements * Add missing file change * Fix build error Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * work in progress * completed input view * completed input label & work in progress for inputvalidation * [UWP] Fix crash when invoking show cards (#4370) * Remove control validation (#4379) * [Android] Fix suffix rendering in labels (#4372) * Remove build files from git * Fix label suffix * [Android] Fix visual input cue to clean the state on instantiation (#4373) * Remove build files from git * Fix preloaded visual cue * [Android] Fix empty date input (#4374) * Remove build files from git * Fix date input to allow being empty on start * complted implementing input validation * [JS] Regenerate package-lock files * code complete * Revert "Merge branch 'jwoo/ios-input-evolution' into feature/inputEvolution" This reverts commit dda9109, reversing changes made to 609f25e. * Emit warning for required inputs without label (#4435) * [UWP] Fix Input.Number validation logic to ensure value is a number (#4432) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [WPF] Fix automation properties (#4371) * Remove build files from git * Fix AutomationProperties for Accessibility * Fix comments from pr Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add warnings for empty labels in required inputs (#4409) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add warning for empty label in required input (#4454) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add input retrieval to inlinr submit actions (#4453) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Fix stretch textblock claiming all visible space (#4452) * Fix elements taking the whole space * Add sample files Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Sample updates (#4455) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix PR comments * Change choiceset returns from null to empty (#4458) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * ios input evolution (#4437) * refactored and fixed bug bash bugs * fixed merge error * added warning messages when there is no error message is present when the input has the validations * refactored code and fixed unit tests * updated failed test card since bad card is fixed Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Revert files that should not be modified Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: David Claux <dclaux@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: jarusse <59999260+jarusse@users.noreply.github.com> Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Add classes for validation * Add interfaces for input validation * [UWP] Input Validation Prototype * Second version of validation * Update some stuff * Add minor fixes and ur * Add multitype label support * Fix break * Add support for card elements as labels * Add automation properties * Add fixes for accessibiloty * Add host config support * Fix accessibility for error messages * Add host config options for validation behavior * Modify host config to show enw options * Add files to project * Remove UWP specific code * Remove Android specific code changes * Update test files * [TS] Input validation (microsoft#4197) * Work in progress * Code complete * Now actually code complete * Fix not all required inputs gathered from ShowCard * Accessibility support * Add aria-required, hide suffix from accessibility * aria-required for Toggle and ChoiceSet * Add sample Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [Shared model] Update namings in host config (microsoft#4213) * Remove validation behaviour from host config * Update namings in hostconfig * Fix build errors * Fix some test json for bugbash * Fix cards with errors * Update long labels to be loooooooooooooooooooooong * [DevSpec] Updates to input validation spec (microsoft#4190) * Input Validation Spec Documents * Fix casing on broken image links' * Updates to document based on discussions and feedback * Minor formatting change Updated the "Start the documentation site" heading to be at the same level as the rest of the headings * Removing instructions around explicit hexo install * [Security] Bump handlebars in /source/nodejs/adaptivecards (microsoft#3692) * Bump handlebars from 4.1.2 to 4.5.3 in /source/community/reactnative (microsoft#3694) * [UWP] Fix null dereference in Media code path (microsoft#3669) [UWP] Fix null dereference in Media code path * [UWP] Fix RendererRegistration error handling and fix inheritance issue with WholeItemsPanel (microsoft#3710) * updated the doc (microsoft#3706) * updated the doc * Updated specs * updated the description * Updated specs * updated the doc to correct wrong info * Updated specs * [Accessibility] Fixing some color contrast issues in the website (microsoft#3698) * Updating adaptivecards.io homepage's roadmap links to point to the updated productboard portal * Fixes microsoft#3577 ; Fixes microsoft#3576: * Fixing outlook.css since that is the style sheet that is being picked up by default when you hit the explorer page * automatic package.json changes * Fixing color syntax * Site readme updates (microsoft#3699) 1. Including PreRequisite section around repo bootstrap linking to root readme 2. Cleaning up build commands to use lerna to be consistent with root readme and removing redundant steps * added test to parse and render all sample cards (microsoft#3679) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [UWP] Remove image comparison from unit tests (microsoft#3724) * [UWP] Remove image comparison from unit tests * Code review feedback * Added MaxActions Limit Check (microsoft#3696) * Added MaxActions limit check and replaced multiple of GetActions() call That returns a structure by value * added UnitTesting and Warning * added UnitTesting and Warning fixed comments Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Jwoo/ios telephony update (microsoft#3680) * updating telephony detection for markdown link * undo uneccesary changes * updated RichTextBlockRenderer to detect Telephony link * updated sample card Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Fix scrolling behaviour in multiline Input.Text (microsoft#3714) * Fix scrolling behaviour in multiline text input * Add test files Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix vertical content alignment for elements in root (microsoft#3716) * [SharedModel] Skip date/time tests outside of Pacific TZ (microsoft#3611) * [SharedModel] Skip date/time tests outside of Pacific TZ Fixes microsoft#3609 * Rename TEST_MODULE_INITIALIZE method * Remove TEST_MODULE_INITIALIZE altogether * Update macro name Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Create cortana-beta-light.json (microsoft#3729) New HostConfig for Cortana Windows UWP beta, light mode. To be added to the drop down as: Cortana (Beta) - Light * Create cortana-beta-dark.json (microsoft#3730) Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> * [Android] Fix to have HH:mm in Input.Time elements (microsoft#3713) * Fix to have short time format * Change helper function * Add unit tets * Add sample test json * Remove unnecessary test file * Fixed microsoft#3741 (microsoft#3743) * Updated Cover FillMode Behavior (microsoft#3725) * Updated Cover FillMode Behavior * Revew Comments Addresssed * adding testing card * Updated file * Updated Handling of Preprocessed Text (microsoft#3727) * Updated preprocessed text handling * updated formatting * Added Accesibility Tags * updated accessibility Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * updated project file to expose media rendere (microsoft#3726) * iOS new layout scheme (microsoft#3687) * Updated iOS layout * removed wrapper on TextBlock and RichTextBlock renderers * updated layout views to use intrinsic contentsize * updated property value for layout vies * Added key value observation for hidden property to allow toggle visibility and the new layout change to work together * Updated views with toggle visibility to update its contentsize based on their visibility changes Updated padding priority for bleeding * restores to working project file * updated project file for xcode * updated for CR comments * Fixed for CR comments Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * updated the gradle property to handle error token (microsoft#3742) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * More feedback updates * Add backwards compatibility section * Update to labels spec to reflect the latest discussions * Add an update to the label spec to cover the current state of discussions * Update some open discussion and comments * Update link * Flesh out host config options * Fix some comments * Fix more comments * Split original spec into two options * Fix comment from discussion * Get the general spec on track with the other two * Add almost final version * Move costing outside of appendix * Add index to point to topics easier * Add table of contents for validation * Add WCA Guidelines * Add requirements * Update specs * Remove markdown from v1 * Make small updates to input validation spec * Add fixes for comments from last meeting * Update host config structure * Take options out of scope for associated inputs * Add changes from 05/26 meeting * Update requirements * Update last details of spec * [Android] Show all ActionSet's in column (microsoft#4181) * Adjust ActionSet container height to fit contents * Add test card * Fix UWP build break after branch change and merge * Revert no longer relevent changes in samples and schema Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: jarusse <59999260+jarusse@users.noreply.github.com> Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> * [UWP] Input Evolution (microsoft#4088) * Re add everything related to UWP * Remove validation behaviour from host config * Remove references to validation behaviour * Update input retrieval * Add changes to respect label and error messages on custom inputs * Remove comment and repeated code * Update namings in hostconfig * Update host config and fixes broken error message setting * Fix first batch of comments in PR * Remove render context from input value constructor * Fix more comments from PR * Fix more comments * Fix text wrapping in error message and bug in time input validation * Fix input retrieval bug Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Input labels and errors support (microsoft#4039) * First working android version for inputs and errors * Clean up android tests * Fix tests for other input types * Update swig files * Fix build error * Remove validation behaviour from host config * Remove validation behaviour references * Working version n1 for visible views only * Add more changes to respect basic properties as spacing * Add fix to compress casting tasks * Fix some behaviours and check that all inputs work * Update host config * Updsate object model file * Readd legacy card import for testing purposes * Fix android not rendering elements * Fix issues found in bug bash' * Fix test fieks * Fix tests Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix casting issue * Add missing file from previous commit * [WPF] Input Evolution (microsoft#4172) * Add NET shared model support and WPF rendering support for labels and error messages * Fix validation bugs * Fix some acessibility issues Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [UWP] Fix inline actions not getting inputs (microsoft#4266) * Fix inline actions not validating inputs * Updated specs Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com> * [UWP] Respect host config formatting for labels (microsoft#4289) * Fix host config on labels * Fix comments * Fix crashes when no input exist in a card (microsoft#4316) * [UWP] Sample custom input (microsoft#4282) * Add sample input and changes the use of internal id for string id * Fix commments from PR * [WPF] Rename the input label host config property to match cpp shared model (microsoft#4308) * Rename the input label host config properties * Remove build files from git * Remove invalid test cards and add new valid test cards * Remove associated inputs from submit actions * Fix failing tests * Fix test errors * Rename custom input to be the same as other renderers (microsoft#4328) * Fix input visibility (microsoft#4306) * Fix crash when clicking inline actin (microsoft#4290) * Fix samples (microsoft#4347) * Remove build files from git * Add properties to hostconfig and fix duplicated id Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [TS] Input accessibility + designer open sample dialog fixes (microsoft#4239) * [JS] Input accessibility and designer fixes * Fix Input.Number min/max not honored when set to 0 * Update package-lock.json * Further package-lock.json updates Co-authored-by: Paul Campbell (DEP) <paulcam@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Ts/input label as label (microsoft#4354) * [JS] Input label as <label> * Fix typo * Update package-lock.json * Another package-lock update * Small preview mode fix Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [Android] fix focus on elements (microsoft#4321) * Add custom input element to verify correct label rendering * Fix Focus Visibility on choiceset elements * Add missing file change * Fix build error Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * work in progress * completed input view * completed input label & work in progress for inputvalidation * [UWP] Fix crash when invoking show cards (microsoft#4370) * Remove control validation (microsoft#4379) * [Android] Fix suffix rendering in labels (microsoft#4372) * Remove build files from git * Fix label suffix * [Android] Fix visual input cue to clean the state on instantiation (microsoft#4373) * Remove build files from git * Fix preloaded visual cue * [Android] Fix empty date input (microsoft#4374) * Remove build files from git * Fix date input to allow being empty on start * complted implementing input validation * [JS] Regenerate package-lock files * code complete * Revert "Merge branch 'jwoo/ios-input-evolution' into feature/inputEvolution" This reverts commit 53b529ae363b826784731511a08453006dd5f168, reversing changes made to e1ef301f3babf7c60a9831f2ca5569c544e26c41. * Emit warning for required inputs without label (microsoft#4435) * [UWP] Fix Input.Number validation logic to ensure value is a number (microsoft#4432) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [WPF] Fix automation properties (microsoft#4371) * Remove build files from git * Fix AutomationProperties for Accessibility * Fix comments from pr Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add warnings for empty labels in required inputs (microsoft#4409) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add warning for empty label in required input (microsoft#4454) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add input retrieval to inlinr submit actions (microsoft#4453) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Fix stretch textblock claiming all visible space (microsoft#4452) * Fix elements taking the whole space * Add sample files Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Sample updates (microsoft#4455) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Change choiceset returns from null to empty (microsoft#4458) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * ios input evolution (microsoft#4437) * refactored and fixed bug bash bugs * fixed merge error * added warning messages when there is no error message is present when the input has the validations * refactored code and fixed unit tests * updated failed test card since bad card is fixed Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix label to make hint always have attention color (microsoft#4456) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fixing .NET CI tests for feature/inputEvolution (microsoft#4462) * Ignoring default value for LabelConfig.inputspacing during serialization * Updating API doc * Fixing regression in WPF renderer processing v1.0 inputs * Reverting changes to default launchSettings for the ImageRenderer sample Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: David Claux <dclaux@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: jarusse <59999260+jarusse@users.noreply.github.com> Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Add classes for validation * Add interfaces for input validation * [UWP] Input Validation Prototype * Second version of validation * Update some stuff * Add minor fixes and ur * Add multitype label support * Fix break * Add support for card elements as labels * Add automation properties * Add fixes for accessibiloty * Add host config support * Fix accessibility for error messages * Add host config options for validation behavior * Modify host config to show enw options * Add files to project * Remove UWP specific code * Remove Android specific code changes * Update test files * [TS] Input validation (microsoft#4197) * Work in progress * Code complete * Now actually code complete * Fix not all required inputs gathered from ShowCard * Accessibility support * Add aria-required, hide suffix from accessibility * aria-required for Toggle and ChoiceSet * Add sample Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [Shared model] Update namings in host config (microsoft#4213) * Remove validation behaviour from host config * Update namings in hostconfig * Fix build errors * Fix some test json for bugbash * Fix cards with errors * Update long labels to be loooooooooooooooooooooong * [DevSpec] Updates to input validation spec (microsoft#4190) * Input Validation Spec Documents * Fix casing on broken image links' * Updates to document based on discussions and feedback * Minor formatting change Updated the "Start the documentation site" heading to be at the same level as the rest of the headings * Removing instructions around explicit hexo install * [Security] Bump handlebars in /source/nodejs/adaptivecards (microsoft#3692) * Bump handlebars from 4.1.2 to 4.5.3 in /source/community/reactnative (microsoft#3694) * [UWP] Fix null dereference in Media code path (microsoft#3669) [UWP] Fix null dereference in Media code path * [UWP] Fix RendererRegistration error handling and fix inheritance issue with WholeItemsPanel (microsoft#3710) * updated the doc (microsoft#3706) * updated the doc * Updated specs * updated the description * Updated specs * updated the doc to correct wrong info * Updated specs * [Accessibility] Fixing some color contrast issues in the website (microsoft#3698) * Updating adaptivecards.io homepage's roadmap links to point to the updated productboard portal * Fixes microsoft#3577 ; Fixes microsoft#3576: * Fixing outlook.css since that is the style sheet that is being picked up by default when you hit the explorer page * automatic package.json changes * Fixing color syntax * Site readme updates (microsoft#3699) 1. Including PreRequisite section around repo bootstrap linking to root readme 2. Cleaning up build commands to use lerna to be consistent with root readme and removing redundant steps * added test to parse and render all sample cards (microsoft#3679) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [UWP] Remove image comparison from unit tests (microsoft#3724) * [UWP] Remove image comparison from unit tests * Code review feedback * Added MaxActions Limit Check (microsoft#3696) * Added MaxActions limit check and replaced multiple of GetActions() call That returns a structure by value * added UnitTesting and Warning * added UnitTesting and Warning fixed comments Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Jwoo/ios telephony update (microsoft#3680) * updating telephony detection for markdown link * undo uneccesary changes * updated RichTextBlockRenderer to detect Telephony link * updated sample card Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Fix scrolling behaviour in multiline Input.Text (microsoft#3714) * Fix scrolling behaviour in multiline text input * Add test files Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix vertical content alignment for elements in root (microsoft#3716) * [SharedModel] Skip date/time tests outside of Pacific TZ (microsoft#3611) * [SharedModel] Skip date/time tests outside of Pacific TZ Fixes microsoft#3609 * Rename TEST_MODULE_INITIALIZE method * Remove TEST_MODULE_INITIALIZE altogether * Update macro name Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Create cortana-beta-light.json (microsoft#3729) New HostConfig for Cortana Windows UWP beta, light mode. To be added to the drop down as: Cortana (Beta) - Light * Create cortana-beta-dark.json (microsoft#3730) Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> * [Android] Fix to have HH:mm in Input.Time elements (microsoft#3713) * Fix to have short time format * Change helper function * Add unit tets * Add sample test json * Remove unnecessary test file * Fixed microsoft#3741 (microsoft#3743) * Updated Cover FillMode Behavior (microsoft#3725) * Updated Cover FillMode Behavior * Revew Comments Addresssed * adding testing card * Updated file * Updated Handling of Preprocessed Text (microsoft#3727) * Updated preprocessed text handling * updated formatting * Added Accesibility Tags * updated accessibility Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * updated project file to expose media rendere (microsoft#3726) * iOS new layout scheme (microsoft#3687) * Updated iOS layout * removed wrapper on TextBlock and RichTextBlock renderers * updated layout views to use intrinsic contentsize * updated property value for layout vies * Added key value observation for hidden property to allow toggle visibility and the new layout change to work together * Updated views with toggle visibility to update its contentsize based on their visibility changes Updated padding priority for bleeding * restores to working project file * updated project file for xcode * updated for CR comments * Fixed for CR comments Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * updated the gradle property to handle error token (microsoft#3742) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * More feedback updates * Add backwards compatibility section * Update to labels spec to reflect the latest discussions * Add an update to the label spec to cover the current state of discussions * Update some open discussion and comments * Update link * Flesh out host config options * Fix some comments * Fix more comments * Split original spec into two options * Fix comment from discussion * Get the general spec on track with the other two * Add almost final version * Move costing outside of appendix * Add index to point to topics easier * Add table of contents for validation * Add WCA Guidelines * Add requirements * Update specs * Remove markdown from v1 * Make small updates to input validation spec * Add fixes for comments from last meeting * Update host config structure * Take options out of scope for associated inputs * Add changes from 05/26 meeting * Update requirements * Update last details of spec * [Android] Show all ActionSet's in column (microsoft#4181) * Adjust ActionSet container height to fit contents * Add test card * Fix UWP build break after branch change and merge * Revert no longer relevent changes in samples and schema Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: jarusse <59999260+jarusse@users.noreply.github.com> Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> * [UWP] Input Evolution (microsoft#4088) * Re add everything related to UWP * Remove validation behaviour from host config * Remove references to validation behaviour * Update input retrieval * Add changes to respect label and error messages on custom inputs * Remove comment and repeated code * Update namings in hostconfig * Update host config and fixes broken error message setting * Fix first batch of comments in PR * Remove render context from input value constructor * Fix more comments from PR * Fix more comments * Fix text wrapping in error message and bug in time input validation * Fix input retrieval bug Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Input labels and errors support (microsoft#4039) * First working android version for inputs and errors * Clean up android tests * Fix tests for other input types * Update swig files * Fix build error * Remove validation behaviour from host config * Remove validation behaviour references * Working version n1 for visible views only * Add more changes to respect basic properties as spacing * Add fix to compress casting tasks * Fix some behaviours and check that all inputs work * Update host config * Updsate object model file * Readd legacy card import for testing purposes * Fix android not rendering elements * Fix issues found in bug bash' * Fix test fieks * Fix tests Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix casting issue * Add missing file from previous commit * [WPF] Input Evolution (microsoft#4172) * Add NET shared model support and WPF rendering support for labels and error messages * Fix validation bugs * Fix some acessibility issues Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [UWP] Fix inline actions not getting inputs (microsoft#4266) * Fix inline actions not validating inputs * Updated specs Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com> * [UWP] Respect host config formatting for labels (microsoft#4289) * Fix host config on labels * Fix comments * Add custom input element to verify correct label rendering * Fix crashes when no input exist in a card (microsoft#4316) * [UWP] Sample custom input (microsoft#4282) * Add sample input and changes the use of internal id for string id * Fix commments from PR * [WPF] Rename the input label host config property to match cpp shared model (microsoft#4308) * Rename the input label host config properties * Remove build files from git * Remove invalid test cards and add new valid test cards * Remove associated inputs from submit actions * Fix failing tests * Fix test errors * Rename custom input to be the same as other renderers (microsoft#4328) * Fix input visibility (microsoft#4306) * Fix crash when clicking inline actin (microsoft#4290) * Fix samples (microsoft#4347) * Remove build files from git * Add properties to hostconfig and fix duplicated id Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [TS] Input accessibility + designer open sample dialog fixes (microsoft#4239) * [JS] Input accessibility and designer fixes * Fix Input.Number min/max not honored when set to 0 * Update package-lock.json * Further package-lock.json updates Co-authored-by: Paul Campbell (DEP) <paulcam@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Change async operations to work on a concurrent manner (microsoft#4346) * Ts/input label as label (microsoft#4354) * [JS] Input label as <label> * Fix typo * Update package-lock.json * Another package-lock update * Small preview mode fix Co-authored-by: Paul Campbell <paulcam@microsoft.com> * [Android] fix focus on elements (microsoft#4321) * Add custom input element to verify correct label rendering * Fix Focus Visibility on choiceset elements * Add missing file change * Fix build error Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * work in progress * completed input view * completed input label & work in progress for inputvalidation * [UWP] Fix crash when invoking show cards (microsoft#4370) * Remove control validation (microsoft#4379) * [Android] Fix suffix rendering in labels (microsoft#4372) * Remove build files from git * Fix label suffix * [Android] Fix visual input cue to clean the state on instantiation (microsoft#4373) * Remove build files from git * Fix preloaded visual cue * [Android] Fix empty date input (microsoft#4374) * Remove build files from git * Fix date input to allow being empty on start * complted implementing input validation * [JS] Regenerate package-lock files * code complete * Revert "Merge branch 'jwoo/ios-input-evolution' into feature/inputEvolution" This reverts commit 53b529ae363b826784731511a08453006dd5f168, reversing changes made to e1ef301f3babf7c60a9831f2ca5569c544e26c41. * Emit warning for required inputs without label (microsoft#4435) * [UWP] Fix Input.Number validation logic to ensure value is a number (microsoft#4432) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [WPF] Fix automation properties (microsoft#4371) * Remove build files from git * Fix AutomationProperties for Accessibility * Fix comments from pr Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add warnings for empty labels in required inputs (microsoft#4409) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add warning for empty label in required input (microsoft#4454) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add input retrieval to inlinr submit actions (microsoft#4453) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Fix stretch textblock claiming all visible space (microsoft#4452) * Fix elements taking the whole space * Add sample files Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Sample updates (microsoft#4455) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix PR comments * Change choiceset returns from null to empty (microsoft#4458) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * ios input evolution (microsoft#4437) * refactored and fixed bug bash bugs * fixed merge error * added warning messages when there is no error message is present when the input has the validations * refactored code and fixed unit tests * updated failed test card since bad card is fixed Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Revert files that should not be modified Co-authored-by: Rebecca Muraira <rebecch@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: David Claux <dclaux@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: jarusse <59999260+jarusse@users.noreply.github.com> Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the PR for the spec document to go into main; the 2 documents to review are InputValidation.md and InputLabels.md
Microsoft Reviewers: Open in CodeFlow