Fix issue with dotnet template null handling - #5964
Merged
Merged
Conversation
|
|
jwoo-msft
requested changes
Jun 5, 2021
ghost
added
the
jwoo-msft
approved these changes
Jun 8, 2021
paulcam206
pushed a commit
that referenced
this pull request
Aug 19, 2021
* Fix issue with dotnet template null handling * Add tests Co-authored-by: Greg Hitchon <ghitchon@corrosionservice.com> (cherry picked from commit 58abbf5)
jonmill
pushed a commit
that referenced
this pull request
Aug 25, 2021
* Fix issue with dotnet template null handling * Add tests Co-authored-by: Greg Hitchon <ghitchon@corrosionservice.com> (cherry picked from commit 58abbf5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #5963
Description
It seems the null substitution options were being overwritten within the
AdaptiveCardsTemplateVisitorclass.How Verified
Added two unit tests for the cases with/without null substitution.
Microsoft Reviewers: Open in CodeFlow