Skip to content

[iOS] Fixed #6219, #6222 - #6233

Merged
jwoo-msft merged 5 commits into
mainfrom
jwoo/ios-background-image-update
Aug 25, 2021
Merged

[iOS] Fixed #6219, #6222#6233
jwoo-msft merged 5 commits into
mainfrom
jwoo/ios-background-image-update

Conversation

@jwoo-msft

@jwoo-msft jwoo-msft commented Aug 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Related Issue

Fixed #6219, Fixed #6222

Description

  • scaled background image view to the minimum size that can cover the target view.
  • simplified the logic for background image when its dimension is less than the target view.
  • refactored code
    • grouped constraints and activate them at once for better performance.
    • reduced priority for min-height to 999 from max as it interferes with background image height.

Sample Card

AdaptiveCard.BackgroundImage.FillMode.Cover.SmallImage.json

How Verified

How you verified the fix, including one or all of the following:

  1. New unit test is added
  2. Existing unit tests are tested
  3. Relavent sample cards are tested.
    Screen Shot 2021-08-20 at 2 58 27 PM

Screen Shot 2021-08-20 at 4 21 36 PM

Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft changed the title [iOS] Fixed #6219 [iOS] Fixed #6219, #6222 Aug 20, 2021
@jwoo-msft
jwoo-msft enabled auto-merge (squash) August 20, 2021 23:30
almedina-ms
almedina-ms reviewed Aug 24, 2021
View reviewed changes
Comment thread samples/v1.2/Tests/AdaptiveCard.BackgroundImage.FillMode.Cover.SmallImage.json Outdated
almedina-ms
almedina-ms approved these changes Aug 25, 2021
View reviewed changes

@almedina-ms almedina-ms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

paulcam206
paulcam206 approved these changes Aug 25, 2021
View reviewed changes
Comment thread samples/v1.2/Tests/AdaptiveCard.BackgroundImage.FillMode.Cover.SmallImage.json Outdated
@jwoo-msft
jwoo-msft merged commit 3383b81 into main Aug 25, 2021
@jwoo-msft
jwoo-msft deleted the jwoo/ios-background-image-update branch August 25, 2021 19:48
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
@jwoo-msft @michaelfarnsworth
[iOS] Fixed microsoft#6219, microsoft#6222 (microsoft#6233)
1043b63 
* [iOS] Fixed microsoft#6219

* Updated sample card

* [iOS] Fixes 6222
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
@jwoo-msft
[iOS] Fixed microsoft#6219, microsoft#6222 (microsoft#6233)
36cbd69 
* [iOS] Fixed microsoft#6219

* Updated sample card

* [iOS] Fixes 6222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulcam206 paulcam206 paulcam206 approved these changes
@almedina-ms almedina-ms almedina-ms approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Rendering][iOS] Background Image doesn't fill the card. [Rendering][iOS] Image too stretched one the ACRView

4 participants

@jwoo-msft @paulcam206 @almedina-ms @jonmill