Add the validator attribute, validation rule and validator#133
Closed
xuzhg wants to merge 1 commit into
Closed
Conversation
Member
|
How is this branch different than the other validation branch? Are they alternative approaches, or complementary? Can you explain why there is a need to introduce attributes? Personally I am of the opinion that we overuse attributes in .net libraries. What is the benefit they bring in this case? |
Contributor
Contributor
Author
|
Close this because we are moving to #152. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@PerthCharern @darrelmiller
I want to implement the validation logic for the Open API element. Here's my design (it's not finished).
General design:
Can validation each part individually. for example, Developer create a object, he can call the validate api to validate the created object.
Validate rule can be customized. For example, developer can create their own validation rules.
Detail:
OpenApiElementValidator.cs has the public apis
.\Validations\Validator has the validator classes for each element.
.\Validations\Rules has the rule classes for each element.
Each model class has an attribute to identify the validator.
Please have a look and give me some feedback.