Skip to content

Partially revert #41044, restoring parameter destructurings in d.ts files - #50779

Merged
jakebailey merged 2 commits into
microsoft:mainfrom
jakebailey:fix-50707
Sep 15, 2022
Merged

Partially revert #41044, restoring parameter destructurings in d.ts files#50779
jakebailey merged 2 commits into
microsoft:mainfrom
jakebailey:fix-50707

Conversation

@jakebailey

@jakebailey jakebailey commented Sep 14, 2022

Copy link
Copy Markdown
Member

Fixes #50707 (at least to the extent that we have the pre-4.8 behavior).

In a followup PR, I can remove these destructurings/bindings/whatevertheyrecalleds in the declaration emitter.

Note that the new errors added in #41044 remain. I guess the PR had two somewhat-related changes in it?

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Sep 14, 2022
@jakebailey

Copy link
Copy Markdown
Member Author

@typescript-bot cherry-pick this to release-4.8

Technically, this depends on #50538 but I'm curious to see if it'll work. Probably not.

@typescript-bot

typescript-bot commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

Heya @jakebailey, I've started to run the task to cherry-pick this into release-4.8 on this PR at ba4a466. You can monitor the build here.

@typescript-bot

Copy link
Copy Markdown
Contributor

Hey @jakebailey, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.8 manually.

@andrewbranch

Copy link
Copy Markdown
Member

@typescript-bot cherry-pick this to release-4.8

@typescript-bot

typescript-bot commented Sep 22, 2022

Copy link
Copy Markdown
Contributor

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.8 on this PR at ba4a466. You can monitor the build here.

@typescript-bot

Copy link
Copy Markdown
Contributor

Hey @andrewbranch, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.8 manually.

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate identifier in function declaration due to stripped property renames

4 participants