Skip to content

Do not require import attributes for JSON imports in --module node16#60673

Merged
andrewbranch merged 2 commits into
microsoft:mainfrom
andrewbranch:bug/60589
Dec 4, 2024
Merged

Do not require import attributes for JSON imports in --module node16#60673
andrewbranch merged 2 commits into
microsoft:mainfrom
andrewbranch:bug/60589

Conversation

@andrewbranch

@andrewbranch andrewbranch commented Dec 3, 2024

Copy link
Copy Markdown
Member

Fixes #60589

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Dec 3, 2024
@andrewbranch

Copy link
Copy Markdown
Member Author

@typescript-bot cherry-pick this to release-5.7

@typescript-bot

typescript-bot commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick this to release-5.7 ✅ Started ✅ Results

@typescript-bot

Copy link
Copy Markdown
Contributor

Hey, @andrewbranch! I've created #60674 for you.

@andrewbranch
andrewbranch merged commit 9bf5aa7 into microsoft:main Dec 4, 2024
@andrewbranch
andrewbranch deleted the bug/60589 branch December 4, 2024 16:47
DanielRosenwasser pushed a commit that referenced this pull request Dec 4, 2024
…e-5.7 (#60674)

Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
@sandersn sandersn removed this from PR Backlog Apr 22, 2025
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Module resolution: Regression in JSON import using Node16 resolution

4 participants