Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[CodeQL] Fix remaining SM00431 alerts - #6561

Merged
tracyboehrer merged 1 commit into
mainfrom
southworks/fix/codql-sm00431-alerts
Nov 30, 2022
Merged

[CodeQL] Fix remaining SM00431 alerts#6561
tracyboehrer merged 1 commit into
mainfrom
southworks/fix/codql-sm00431-alerts

Conversation

@ceciliaavila

Copy link
Copy Markdown
Collaborator

Fixes #6543

Description

This PR fixes the CodeQL SM00431 alert related to exposing an exception to the end user (more information).

Specific Changes

  • Update response ConnectWebSocketAsync usage, passing exception message.
  • Update EndToEndMiniLoadTests not to expose exception bodies.

Testing

CodeQL local report for exception exposure with no alerts:
image
Tests passed after the changes:
image

@ceciliaavila ceciliaavila added the Automation: No parity PR does not need to be applied to other languages. label Nov 22, 2022
@ceciliaavila
ceciliaavila requested a review from a team as a code owner November 22, 2022 13:00
@coveralls

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 330441

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 79.068%

Totals Coverage Status
Change from base Build 329938: 0.006%
Covered Lines: 25702
Relevant Lines: 32506

💛 - Coveralls

@tracyboehrer
tracyboehrer merged commit 1566391 into main Nov 30, 2022
@tracyboehrer
tracyboehrer deleted the southworks/fix/codql-sm00431-alerts branch November 30, 2022 22:45
This was referenced May 14, 2026
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CodeQL alert SM00431: Information exposure through an exception in microsoft/microsoft/botbuilder-dotnet/botbuilder-dotnet

4 participants