Custom status support - #26
Merged
Merged
Conversation
shreyas-gopalakrishna
force-pushed
the
shreyasg/custom-status
branch
from
April 6, 2022 17:14
2d32207 to
6088e3b
Compare
cgillum
reviewed
Apr 6, 2022
cgillum
left a comment
cgillum
left a comment
Member
There was a problem hiding this comment.
Happy to see this coming along! See my initial feedback below. Let me know if you're still stuck on the test case and I can help debug.
| OrchestratorService.OrchestratorResponse.Builder responseBuilder = OrchestratorService.OrchestratorResponse.newBuilder(); | ||
| responseBuilder.setInstanceId(orchestratorRequest.getInstanceId()); | ||
| responseBuilder.addAllActions(actions); | ||
| if(taskOrchestrationExecutor.getCustomStatus() != null) { |
Member
There was a problem hiding this comment.
Same comment about allowing a null custom status.
Member
There was a problem hiding this comment.
I'm actually a bit surprised this code is duplicated in two places. Does it need to be?
davidmrdavid
reviewed
Apr 6, 2022
davidmrdavid
left a comment
davidmrdavid
left a comment
Member
There was a problem hiding this comment.
Left some comments as well, mostly just adding to the existing discussion.
So happy to see the quick progress here, good job folks!
| OrchestratorService.OrchestratorResponse.Builder responseBuilder = OrchestratorService.OrchestratorResponse.newBuilder(); | ||
| responseBuilder.setInstanceId(orchestratorRequest.getInstanceId()); | ||
| responseBuilder.addAllActions(actions); | ||
| if(taskOrchestrationExecutor.getCustomStatus() != null) { |
Member
There was a problem hiding this comment.
I'm actually a bit surprised this code is duplicated in two places. Does it need to be?
cgillum
reviewed
Apr 7, 2022
cgillum
left a comment
cgillum
left a comment
Member
There was a problem hiding this comment.
This seems much cleaner, thanks! A few more small suggestions.
… OrchestrationMetadata
cgillum
requested changes
Apr 8, 2022
| private final String customStatus; | ||
|
|
||
| public TaskOrchestratorResult(Collection<OrchestratorService.OrchestratorAction> actions, String customStatus) { | ||
| this.actions = ImmutableList.<OrchestratorService.OrchestratorAction>builder().addAll(actions).build(); |
Member
There was a problem hiding this comment.
Instead of using the 3rd party ImmutableList, let's just use Collections.unmodifiableCollection()
Suggested change
| this.actions = ImmutableList.<OrchestratorService.OrchestratorAction>builder().addAll(actions).build(); | |
| this.actions = Collections.unmodifiableCollection(actions); |
| this.customStatus = customStatus; | ||
| } | ||
|
|
||
| public Collection<OrchestratorService.OrchestratorAction> getActions() { |
Member
There was a problem hiding this comment.
Alternatively, you could simply change the return type of this method to Iterable<OrchestratorService.OrchestratorAction> to achieve the same external immutability result.
Suggested change
| public Collection<OrchestratorService.OrchestratorAction> getActions() { | |
| public Iterable<OrchestratorService.OrchestratorAction> getActions() { |
kaibocai
approved these changes
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for custom status with integration test
resolves #7