Skip to content

[Do Not Review] Validate sample builds with full MUX build - #11242

Open
harshit7962 wants to merge 9 commits into
winui3/mainfrom
user/hmishra/gh-sample-builds-restore-main-clean
Open

[Do Not Review] Validate sample builds with full MUX build#11242
harshit7962 wants to merge 9 commits into
winui3/mainfrom
user/hmishra/gh-sample-builds-restore-main-clean

Conversation

@harshit7962

@harshit7962 harshit7962 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Validation-only PR for task 62750648.

This PR validates the minimal GitHub sample/scenario app validation changes needed to restore parity with the previous ADO PR-XAML validation path.

Related ADO PR: https://dev.azure.com/microsoft/WinUI/_git/microsoft-ui-xaml-lift/pullrequest/16236680

What changed

  • Validates the ADO pipeline/template changes from user/hmishra/gh-ado-sample-builds-restore-main-clean.
  • Keeps WinUIGallery skipped for GitHub-backed sample validation, matching the intended validation scope.
  • Carries the DisableXamlGeneratedMain source fix in this GitHub validation branch because the OneBranch GitHub PR build consumes sample source from refs/pull/11242/merge.
  • Adds restore-condition support so skipped GitHub-only sample entries also skip their restore step, not only their build step.

Why additional changes were needed

The first validation pass exposed that the GitHub-backed OneBranch run does not consume all inputs from the ADO branch in the same way as the old ADO PR-XAML validation. Pipeline templates come from the ADO repo resource, but sample source under $(Build.SourcesDirectory) comes from the GitHub PR merge commit. Because of that split, the DisableXamlGeneratedMain source fix had to be present in this GitHub PR as well as in the ADO branch; otherwise the run continued to build stale sample source and failed on missing XamlGeneratedProgram / wXamlGeneratedMain.

After that was fixed, validation uncovered a second parity gap: WinUIGallery build was already skipped for GitHub-backed validation, but its restore step still ran unconditionally. That caused restore to fail before package references were even evaluated because Samples\WinUIGallery\WinUIGallery.slnx is not present in the GitHub validation checkout. The follow-up template change makes restore obey the same skip condition as build, preserving the previous validation contract instead of expanding the GitHub validation scope.

Validation

Final linked OneBranch build: https://dev.azure.com/microsoft/WinUI/_build/results?buildId=153357322

GitHub now reports WinUI-GitHub-PR (OneBranch) as passing. The ADO build completed as "succeeded with issues", with warnings only; the prior DisableXamlGeneratedMain and WinUIGallery.slnx restore failures did not recur.

This PR is for validation only and should not be completed.

@harshit7962
harshit7962 requested a review from a team as a code owner July 16, 2026 07:25
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the needs-triage Issue needs to be triaged by the area owners label Jul 16, 2026
@harshit7962
harshit7962 force-pushed the user/hmishra/gh-sample-builds-restore-main-clean branch 2 times, most recently from 405539a to cc6f84e Compare July 21, 2026 09:20
@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962
harshit7962 force-pushed the user/hmishra/gh-sample-builds-restore-main-clean branch from cc6f84e to 1585d91 Compare July 23, 2026 10:52
@harshit7962 harshit7962 changed the title [Do Not Review] Restore GitHub sample app build validation [Do Not Review] Validate sample builds with full MUX build Jul 23, 2026
@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962
harshit7962 force-pushed the user/hmishra/gh-sample-builds-restore-main-clean branch from 1585d91 to 58f1106 Compare July 25, 2026 06:33
@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962
harshit7962 changed the base branch from winui3/main to main July 25, 2026 06:33
@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

Restore custom entry-point implementations and C# application definition includes so the re-enabled sample validation can build these samples.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 4202fe9c-76e5-4d5e-9948-0e8313caf9a6
@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

Keep the custom entry-point fix but do not add duplicate ApplicationDefinition items for the C# DisableXamlGeneratedMain samples.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 4202fe9c-76e5-4d5e-9948-0e8313caf9a6
@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

sakshisharma150905 pushed a commit that referenced this pull request Aug 3, 2026
…rce fixes

Mirrors the public-source half of Harshit's #11288/#11242 (needed because the
GitHub leg builds sample SOURCE from this checkout):
- DisableXamlGeneratedMain Program.cs/program.cpp custom entry points
- WinUIGallery submodule pointer bump
- eng/Versions.props IXP transport 2.0.11 -> 2.1.4 (also compiles InkCanvas natively)

Throwaway validation scaffolding; not part of the real PR.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9a62165c-a6df-4eff-b43e-ba28621cbaef
@harshit7962

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-triage Issue needs to be triaged by the area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[WinUI OSS] Restore scenario and sample app build coverage

1 participant