pr7: Check out the WinUIGallery submodule in GitHub PR validation - #11359
Open
pranav-gupta-msft wants to merge 2 commits into
Open
pr7: Check out the WinUIGallery submodule in GitHub PR validation#11359pranav-gupta-msft wants to merge 2 commits into
pranav-gupta-msft wants to merge 2 commits into
Conversation
Samples/WinUIGallery is a committed submodule on winui3/main, but build/WinUI-GitHub-PR.yml pinned git.submodules to false, so PR builds got an empty directory. Enable submodule checkout so MUXControls.Test's GenerateWinUIGalleryTestData target works in GitHub PR builds. AB#62718749 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6c5e3c0f-d12b-42af-a821-9ebc768faeb3
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
added
the
needs-triage
…gallery-pr7-v0.0003
Member
Author
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
Member
Author
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Samples/WinUIGalleryis a committed submodule onwinui3/main(github.com/microsoft/WinUI-Gallery @29f62479), butbuild/WinUI-GitHub-PR.ymlpinsgit.submodulestofalse, so PR builds get an empty directory. The internalWinUI-PR.ymlsets nogit:block at all and inherits the OneBranch default — which is exactly whyMUXControls.Test'sGenerateWinUIGalleryTestDatatarget worked internally only.Change
The lightweight
ValidateGitHubPrContextjob keepscheckout: self / submodules: false— it does no build and does not need the Gallery clone.Validation
Reproduced locally in a
winui3/mainworktree with the submodule initialized and the paired csproj change applied:msb /restore controls\test\MUXControls.Test\MUXControls.Test.csproj(IsInternalWinUIBuild= false)BuildOutput\bin\amd64chk\Test\WinUIGalleryTestData.xmlproduced — 44,897 bytes, 19 tables / 120 rows, byte-identical to the internal buildControlInfoData.jsonremovedWinUI-GitHub-PR.ymlYAML parsegit: {submodules: True})Notes
git.submodulesis global to this pipeline, so every job now clones WinUI-Gallery. Acceptable — it is a public, moderately sized repo.winui3/main, which triggers the very pipeline being edited.Exists(...)instead ofIsInternalWinUIBuild. Order does not matter; each is inert without the other.AB#62718749
Supersedes #11345, which hit a transient agent failure (504 Gateway Timeout while installing the .NET SDK, causing
MSB4236: The SDK 'Microsoft.NET.Sdk' specified could not be foundin the x64fre leg). Same commit, rebased onto the latestwinui3/main.