Python: filter improvements - #10588
Merged
Merged
Conversation
markwallace-microsoft
added
the
python
eavanvalkenburg
enabled auto-merge
February 18, 2025 10:25
eavanvalkenburg
force-pushed
the
filter_samples
branch
from
February 18, 2025 10:25
e4b67cb to
b992a73
Compare
eavanvalkenburg
marked this pull request as draft
February 18, 2025 12:25
auto-merge was automatically disabled
February 18, 2025 12:25
Pull request was converted to draft
eavanvalkenburg
changed the title
Contributor
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
eavanvalkenburg
marked this pull request as ready for review
February 18, 2025 14:02
eavanvalkenburg
force-pushed
the
filter_samples
branch
from
February 18, 2025 14:02
2ee9b03 to
dbad2ae
Compare
shethaadit
approved these changes
Feb 18, 2025
TaoChenOSU
approved these changes
Feb 18, 2025
moonbox3
approved these changes
Feb 19, 2025
moonbox3
enabled auto-merge
February 19, 2025 00:34
4 tasks
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Fixes some inconsistency in the filter setup between dotnet and python Adds a sample for how to use a filter to retry a prompt with a different model. Adds a sample for semantic caching Closes: microsoft#10572 microsoft#5924 microsoft#10595 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes some inconsistency in the filter setup between dotnet and python
Adds a sample for how to use a filter to retry a prompt with a different model.
Adds a sample for semantic caching
Closes: #10572 #5924 #10595
Description
Contribution Checklist