Skip to content

Python: Improve Bedrock service setup docs - #10772

Merged
TaoChenOSU merged 7 commits into
microsoft:mainfrom
TaoChenOSU:taochen/python-improve-bedrock-setup-docs
Mar 4, 2025
Merged

Python: Improve Bedrock service setup docs#10772
TaoChenOSU merged 7 commits into
microsoft:mainfrom
TaoChenOSU:taochen/python-improve-bedrock-setup-docs

Conversation

@TaoChenOSU

@TaoChenOSU TaoChenOSU commented Mar 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation and Context

Closing: #9910

Description

  1. Add detailed instructions on how to setup one's environment to use Bedrock services, including models and agents.
  2. Re-enable bedrock integration tests.
  3. Some other cleanups.

Contribution Checklist

@TaoChenOSU TaoChenOSU added the python Pull requests for the Python Semantic Kernel label Mar 3, 2025
@TaoChenOSU TaoChenOSU self-assigned this Mar 3, 2025
@TaoChenOSU
TaoChenOSU requested a review from a team as a code owner March 3, 2025 22:33
@github-actions github-actions Bot changed the title Improve Bedrock service setup docs Python: Improve Bedrock service setup docs Mar 3, 2025
@TaoChenOSU TaoChenOSU linked an issue Mar 3, 2025 that may be closed by this pull request
Python: document region setup for Bedrock #9910
Closed
@markwallace-microsoft

markwallace-microsoft commented Mar 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/ai/bedrock/services
   bedrock_chat_completion.py1351490%115, 137, 162, 166–169, 227, 245–264, 323
   bedrock_text_completion.py56296%94, 117
   bedrock_text_embedding.py44198%93
TOTAL18981240687% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3172 5 💤 0 ❌ 0 🔥 1m 44s ⏱️

TaoChenOSU
TaoChenOSU commented Mar 3, 2025
View reviewed changes
Comment thread python/tests/integration/completions/chat_completion_test_base.py
@TaoChenOSU
TaoChenOSU enabled auto-merge March 3, 2025 23:28
@TaoChenOSU
TaoChenOSU added this pull request to the merge queue Mar 3, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 3, 2025
@TaoChenOSU
TaoChenOSU added this pull request to the merge queue Mar 3, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 3, 2025
@moonbox3
moonbox3 added this pull request to the merge queue Mar 3, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 4, 2025
@TaoChenOSU
TaoChenOSU enabled auto-merge March 4, 2025 00:19
@TaoChenOSU
TaoChenOSU added this pull request to the merge queue Mar 4, 2025
Merged via the queue into microsoft:main with commit 8fd6da2 Mar 4, 2025
@TaoChenOSU
TaoChenOSU deleted the taochen/python-improve-bedrock-setup-docs branch March 4, 2025 00:28
@github-project-automation github-project-automation Bot moved this to Sprint: Done in Semantic Kernel Mar 4, 2025
rracanicci pushed a commit to rracanicci/semantic-kernel that referenced this pull request Mar 5, 2025
@TaoChenOSU @rracanicci
Python: Improve Bedrock service setup docs (microsoft#10772)
c3f1abd 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Closing: microsoft#9910

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
1. Add detailed instructions on how to setup one's environment to use
Bedrock services, including models and agents.
2. Re-enable bedrock integration tests.
3. Some other cleanups.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
musale pushed a commit to musale/semantic-kernel that referenced this pull request Mar 10, 2025
@TaoChenOSU @musale
Python: Improve Bedrock service setup docs (microsoft#10772)
f8cbb06 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Closing: microsoft#9910

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
1. Add detailed instructions on how to setup one's environment to use
Bedrock services, including models and agents.
2. Re-enable bedrock integration tests.
3. Some other cleanups.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
jcruzmot-te pushed a commit to thousandeyes/aia-semantic-kernel that referenced this pull request Sep 15, 2025
@TaoChenOSU Javier
Python: Improve Bedrock service setup docs (microsoft#10772)
2a552e9 
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Closing: microsoft#9910

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
1. Add detailed instructions on how to setup one's environment to use
Bedrock services, including models and agents.
2. Re-enable bedrock integration tests.
3. Some other cleanups.

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alliscode alliscode alliscode approved these changes
@moonbox3 moonbox3 moonbox3 approved these changes

Assignees

@TaoChenOSU TaoChenOSU

Labels

documentation python Pull requests for the Python Semantic Kernel

Projects

Semantic Kernel
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python: document region setup for Bedrock

4 participants

@TaoChenOSU @markwallace-microsoft @alliscode @moonbox3