.Net: Fix VertexAI global endpoint URI construction (#13620) - #13621
Merged
rogerbarreto merged 2 commits intoMay 1, 2026
Conversation
The global VertexAI location uses `https://aiplatform.googleapis.com` rather than the regional `https://{location}-aiplatform.googleapis.com` pattern. This adds a `GetVertexAIBaseUri` helper to ClientBase that selects the correct base URI and updates all VertexAI clients (chat completion, token counter, embeddings) to use it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
moonbox3
added
.NET
|
Any idea on when this PR will be reviewed? We have run into this bug in production as well and it removes our ability to use preview models without a janky workaround. Thanks Schmitt and to the Microsoft team for handling this! |
rogerbarreto
approved these changes
Apr 30, 2026
rogerbarreto
temporarily deployed
to
integration
April 30, 2026 13:12 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the .NET Google connectors’ Vertex AI endpoint construction so that location=global correctly targets the global Vertex AI host (https://aiplatform.googleapis.com) instead of the regional host pattern (https://{location}-aiplatform.googleapis.com), and adds tests to prevent regressions.
Changes:
- Added a
ClientBase.GetVertexAIBaseUri(location)helper to select the correct Vertex AI host for global vs regional locations. - Updated Vertex AI-backed clients (embeddings, Gemini chat, Gemini token counting) to build request URIs using the new helper.
- Added unit tests to verify global and regional host selection and to treat
"global"as an accepted location segment.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dotnet/src/Connectors/Connectors.Google/Core/VertexAI/VertexAIEmbeddingClient.cs | Uses GetVertexAIBaseUri(location) when constructing the embeddings endpoint URI. |
| dotnet/src/Connectors/Connectors.Google/Core/Gemini/Clients/GeminiTokenCounterClient.cs | Uses GetVertexAIBaseUri(location) when constructing the Vertex AI token counting endpoint URI. |
| dotnet/src/Connectors/Connectors.Google/Core/Gemini/Clients/GeminiChatCompletionClient.cs | Uses GetVertexAIBaseUri(location) when constructing Vertex AI chat generation/streaming endpoint URIs. |
| dotnet/src/Connectors/Connectors.Google/Core/ClientBase.cs | Introduces GetVertexAIBaseUri helper with global vs regional host selection. |
| dotnet/src/Connectors/Connectors.Google.UnitTests/Core/VertexAI/VertexAIClientEmbeddingsGenerationTests.cs | Adds coverage ensuring global vs regional endpoints are selected correctly for embeddings. |
| dotnet/src/Connectors/Connectors.Google.UnitTests/Core/Gemini/Clients/GeminiCountingTokensTests.cs | Adds coverage ensuring global vs regional endpoints are selected correctly for token counting. |
| dotnet/src/Connectors/Connectors.Google.UnitTests/Core/Gemini/Clients/GeminiChatGenerationTests.cs | Adds coverage ensuring global vs regional endpoints are selected correctly for chat generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rogerbarreto
enabled auto-merge
April 30, 2026 21:19
peibekwe
approved these changes
Apr 30, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global VertexAI location uses
https://aiplatform.googleapis.comrather than the regionalhttps://{location}-aiplatform.googleapis.compattern. This adds aGetVertexAIBaseUrihelper to ClientBase that selects the correct base URI and updates all VertexAI clients (chat completion, token counter, embeddings) to use it.