Skip to content

Python: Vertex AI Connector - #7481

Merged
TaoChenOSU merged 15 commits into
microsoft:mainfrom
TaoChenOSU:taochen/vertex-ai-connector
Jul 31, 2024
Merged

Python: Vertex AI Connector#7481
TaoChenOSU merged 15 commits into
microsoft:mainfrom
TaoChenOSU:taochen/vertex-ai-connector

Conversation

@TaoChenOSU

@TaoChenOSU TaoChenOSU commented Jul 27, 2024

Copy link
Copy Markdown
Contributor

Motivation and Context

We are adding a new AI connector for the talking to the Gemini API on Google Vertex AI: https://cloud.google.com/vertex-ai/generative-ai/docs/multimodal/overview

Note that this is for Gemini hosted on Vertex AI. Google also offers Gemini access on their Google AI platform: https://cloud.google.com/vertex-ai/generative-ai/docs/migrate/migrate-google-ai. We will have another connector along with this for accessing Gemini on Google AI.

Description

The new connector contains 3 AI services:

  • Chat completion
  • Text completion
  • Text embedding

TODO: Function calling.

Function calling is not included in this PR to reduce to the size of the PR.

Contribution Checklist

@TaoChenOSU TaoChenOSU added PR: in progress Under development and/or addressing feedback python Pull requests for the Python Semantic Kernel labels Jul 27, 2024
@TaoChenOSU TaoChenOSU self-assigned this Jul 27, 2024
@TaoChenOSU
TaoChenOSU requested a review from a team as a code owner July 27, 2024 00:00
@github-actions github-actions Bot changed the title Vertex AI Connector Python: Vertex AI Connector Jul 27, 2024
@markwallace-microsoft

markwallace-microsoft commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

Py3.10 Test Coverage

Python 3.10 Test Coverage Report
FileStmtsMissCoverMissing
semantic_kernel
   kernel.py157994%145, 156, 160, 200–201, 310–313, 422
semantic_kernel/connectors/ai/azure_ai_inference/services
   azure_ai_inference_chat_completion.py149497%169, 312, 416, 430
semantic_kernel/connectors/ai/embeddings
   embedding_generator_base.py8188%50
semantic_kernel/connectors/ai/hugging_face/services
   hf_text_completion.py54394%95, 103, 134
   hf_text_embedding.py32584%77–81
semantic_kernel/connectors/openapi_plugin
   openapi_manager.py58297%110–111
   openapi_parser.py88199%127
   openapi_runner.py105298%181–182
semantic_kernel/connectors/openapi_plugin/models
   rest_api_operation.py129199%240
semantic_kernel/functions
   kernel_function_decorator.py98199%102
   kernel_function_from_method.py96199%153
   kernel_function_from_prompt.py154795%165–166, 180, 201, 219, 239, 322
   kernel_plugin.py187299%472, 475
semantic_kernel/planners
   plan.py2344581%52, 161–163, 195, 212–225, 262, 267, 275–276, 286–289, 306, 311, 327, 330–335, 353, 358, 361, 363, 370, 384–386, 391–395
semantic_kernel/planners/function_calling_stepwise_planner
   function_calling_stepwise_planner.py116497%143, 187–188, 196
semantic_kernel/planners/sequential_planner
   sequential_planner.py64691%69, 73, 107, 123, 132–133
   sequential_planner_extensions.py50982%29–30, 52, 106–120
   sequential_planner_parser.py771284%64–72, 91, 115–118
semantic_kernel/schema
   kernel_json_schema_builder.py119596%48, 82, 204, 208–209
semantic_kernel/template_engine/blocks
   code_block.py77199%119
   named_arg_block.py43198%98
semantic_kernel/utils/telemetry
   decorators.py113496%232, 240, 243, 252
   user_agent.py16288%18–19
TOTAL772812898% 

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1974 1 💤 0 ❌ 0 🔥 43.247s ⏱️

@TaoChenOSU TaoChenOSU linked an issue Jul 30, 2024 that may be closed by this pull request
Comment thread python/semantic_kernel/connectors/ai/google/shared.py
Comment thread python/semantic_kernel/connectors/ai/google/vertex_ai/services/utils.py Outdated
Comment thread .github/workflows/python-integration-tests.yml
@TaoChenOSU
TaoChenOSU added this pull request to the merge queue Jul 30, 2024
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 30, 2024
@TaoChenOSU
TaoChenOSU added this pull request to the merge queue Jul 30, 2024
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 30, 2024
@moonbox3
moonbox3 enabled auto-merge July 31, 2024 13:51
@moonbox3
moonbox3 added this pull request to the merge queue Jul 31, 2024
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 31, 2024
@moonbox3
moonbox3 added this pull request to the merge queue Jul 31, 2024
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 31, 2024
@TaoChenOSU
TaoChenOSU added this pull request to the merge queue Jul 31, 2024
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 31, 2024
@TaoChenOSU
TaoChenOSU enabled auto-merge July 31, 2024 15:33
@TaoChenOSU
TaoChenOSU added this pull request to the merge queue Jul 31, 2024
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 31, 2024
@TaoChenOSU
TaoChenOSU added this pull request to the merge queue Jul 31, 2024
Merged via the queue into microsoft:main with commit 7997e79 Jul 31, 2024
@TaoChenOSU
TaoChenOSU deleted the taochen/vertex-ai-connector branch July 31, 2024 16:25
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
We are adding a new AI connector for the talking to the Gemini API on
Google Vertex AI:
https://cloud.google.com/vertex-ai/generative-ai/docs/multimodal/overview

Note that this is for Gemini hosted on Vertex AI. Google also offers
Gemini access on their Google AI platform:
https://cloud.google.com/vertex-ai/generative-ai/docs/migrate/migrate-google-ai.
We will have another connector along with this for accessing Gemini on
Google AI.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
The new connector contains 3 AI services:
- Chat completion
- Text completion
- Text embedding

TODO: Function calling.

> Function calling is not included in this PR to reduce to the size of
the PR.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation PR: in progress Under development and/or addressing feedback python Pull requests for the Python Semantic Kernel

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Python: Add Gemini AI Connector

4 participants