Skip to content

File versioning goes backwards in the latest nugets, which may break msi upgrades. #224

Description

@cg110

The file versions have gone backwards in the latest nugets, which is confusing, and may cause issues when shipping the SMO to customers in a msi file.

Depending on msi sequencing or the RemoveExistingProducts, the previous version maybe kept as it's a higher file version.

nuget 180.1.10 has file version 18.100.10.0
nuget 181.1.19 has file version 18.100.1.19

So while the 181 is newer, it's a lower file version, this appears to have been a change made to:
https://github.com/microsoft/sqlmanagementobjects/blob/main/SmoBuild/Version.props

As we've already shipped the 180.1.10 to customers we now have to take care that our msi "downgrades" the files.

I note that the version.props file mentions GacVersion, does SMO even ship/supply dlls that are gac installed? I thought that stopped years ago (we used to install the smo redist exe, and switched to shipping the dlls in our msi file.)

A simple fix would actually to alter the version.props to update:
AssemblyBuildVersion - Essentially the "minor" version for a given major version, starts at 0 and increments with each release branch
and actually start at 10 (as the 180 branch used 10, so that 181 uses 18.100.11.x. And then for 190 major use 0 as a base.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions