Port TypeScript PR #60262: Include non-enumerable keys in __importStar helper#1124
Closed
andrewbranch with Copilot wants to merge 2 commits into
Closed
Port TypeScript PR #60262: Include non-enumerable keys in __importStar helper#1124andrewbranch with Copilot wants to merge 2 commits into
andrewbranch with Copilot wants to merge 2 commits into
Conversation
…r helper Co-authored-by: andrewbranch <3277153+andrewbranch@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Port TypeScript PR #60262: Include non-enumerable keys in __importStar helper
Port TypeScript PR #60262: Include non-enumerable keys in __importStar helper
Jun 9, 2025
Copilot AI
added a commit
that referenced
this pull request
Feb 5, 2026
For JavaScript CommonJS modules with `module.exports = { ... }`,
the binder creates an export= symbol with SymbolFlagsProperty, not
SymbolFlagsValueModule. This was causing TS2497 to be emitted even
when esModuleInterop was enabled.
The fix adds a check in resolveESModuleSymbol to skip the error for
JavaScript files when esModuleInterop is explicitly enabled.
Fixes #1124 and related issue #1054
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the changes from microsoft/TypeScript#60262 to include non-enumerable properties when importing modules with
import * assyntax.Problem
The previous
__importStarhelper only included enumerable properties when performing star imports, which could miss important non-enumerable properties that should be part of the imported namespace.Solution
Updated the
__importStarhelper to useObject.getOwnPropertyNames()(with fallback) instead of a simplefor...inloop. This ensures both enumerable and non-enumerable properties are included.Before:
After:
Changes Made
importStarHelper.Textininternal/printer/helpers.gointernal/transformers/commonjsmodule_test.goTest Results
This change ensures the Go port maintains compatibility with the latest TypeScript behavior for star imports.
Fixes #1119.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.