Skip to content

[openssl] Revert. support for android and wasm32-emscripten - #30053

Closed
talregev wants to merge 1 commit into
microsoft:masterfrom
talregev:TalR/revert_openssl
Closed

[openssl] Revert. support for android and wasm32-emscripten#30053
talregev wants to merge 1 commit into
microsoft:masterfrom
talregev:TalR/revert_openssl

Conversation

@talregev

@talregev talregev commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

Fix #30037
Fix #29947

This is a revert from #27261 merge.
@dg0yt made a fix for android in #29966, but he not sure he can do it for wasm32-emscripten.
I write to him, and I am waiting for his respond.
Also we compile android and wasm32-emscripten openssl for over 2 year now, and now it break. We are seeking for solution.
This state of port openssl is not ideal, but it working. Until we find better solution that will not break these triplets, I am suggesting a revert. At least when I open this PR, there will be a discussion.

If you also compile android and wasm32-emscripten openssl, please write a comment that we know there is more people are using these triplets. Thank you.

I tested this revert on wsl2 ubuntu 22.04 with all android triplets and wasm32-emscripten

@jimwang118 jimwang118 added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label Mar 7, 2023
@dg0yt

dg0yt commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

There is a 3.0.8 port revision which works for the desired community triplets. No one has to use master HEAD.
#29966 is completed now even for emscripten. Time for testing is better spent on that PR than on restoring the mistakes and shortcoming of the past.

@talregev
talregev marked this pull request as draft March 7, 2023 07:21
@talregev

talregev commented Mar 7, 2023

Copy link
Copy Markdown
Contributor Author

There is a 3.0.8 port revision which works for the desired community triplets. No one has to use master HEAD. #29966 is completed now even for emscripten. Time for testing is better spent on that PR than on restoring the mistakes and shortcoming of the past.

I didn't looked for shortcoming of the past, I tested your fix PR for android. Also I asked you a solution for wasm32-emscripten.
Now you present such a solution for wasm32-emscripten and it working, there is no need for this revert.
As I say in your fix PR. I think you doing great progress for vcpkg and openssl.
I also thank you for the fixes and moving forward with openssl.

Me and most of the users are choosing to use master HEAD and try to fix it as much as possible.

  • not be able to be on the master, it mean there will not update from frequently updated ports that we are using.
  • Also there is other workaround we can do. Port overly for openssl. It mean that in the future the other port will support the new openssl port, and it will may break the old openssl in the overlay. That why the most useable case is to be on the master HEAD.

Please remove the unlike reaction from this PR. I tried to give a temporal solution until better one is coming.

@dg0yt

dg0yt commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

Please remove the unlike reaction from this PR.

No. It is already a mild expression for how negative I feel about this PR and also about some comments in the other PR.

@talregev talregev closed this Mar 7, 2023
@talregev

talregev commented Mar 7, 2023

Copy link
Copy Markdown
Contributor Author

@hushanjushi Please test #29966, It a fix for android and wasm32-emscripten.

@talregev

talregev commented Mar 7, 2023

Copy link
Copy Markdown
Contributor Author

Please remove the unlike reaction from this PR.

No. It is already a mild expression for how negative I feel about this PR and also about some comments in the other PR.

I am sorry that I force you to have also the wasm32-emscripten fix on your PR. As you can see, other people including the opensource community I come from use it.
I see you been searching for testing your PRs, for example here: #29575
You can always can approach me directly for detailed with logs testing as I usually do, that can help you fix issues quickly.
I hope it will change your mind about me.

@talregev
talregev deleted the TalR/revert_openssl branch March 7, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[openssl] build failure on wasm32-emscripten [openssl] build failure on Android

3 participants