Don't use uri params for comments document#8860
Merged
Merged
Conversation
lszomoru
approved these changes
Jul 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates comment-document detection to avoid relying on URI query parameters, aligning with VS Code’s comment document URI structure (scheme/authority) and enabling user mention completion to work without parsing query JSON.
Changes:
- Exposes
ReviewCommentController.PREFIXfor reuse outside the controller. - Switches comment-document filtering in
UserCompletionProviderfromuri.queryparsing touri.authorityprefix checks for PR/review comment controllers.
Show a summary per file
| File | Description |
|---|---|
| src/view/reviewCommentController.ts | Makes the review comment controller prefix accessible for identifying review comment documents. |
| src/issues/userCompletionProvider.ts | Replaces query-based comment-document validation with authority-prefix checks using controller IDs. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of microsoft/vscode#326491