Conversation
andresy
reviewed
Jan 13, 2026
| std::unique_ptr<void, std::function<void(void*)>> new_scoped_memory_pool(); | ||
|
|
||
| inline bool is_nax_available() { | ||
| #ifdef MLX_METAL_NO_NAX |
Member
There was a problem hiding this comment.
Wouldn't it be better to positively define MLX_METAL_NAX instead when NAX is present?
Member
Author
There was a problem hiding this comment.
Well this is the minimum edit distance version since there is one path in the cmake that we want to turn off the NAX support for but multiple in the cmake that we want it on for.
Over time I think this makes more sense as by default we will want to build to support neural accelerators... but I'm not so attached to it.. I can rearrange it if needed.
andresy
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases an MLX binary built for macOS 14 or 15 can end up running on a machine with OS 26.2. It will try to load the NAX kernels since it's a run-time check and it will crash.