Fix negative dim indexing#2994
Merged
Merged
Conversation
awni
force-pushed
the
fix-negative-dim-indexing
branch
from
09b46d0 to
bdd3861
Compare
awni
force-pushed
the
fix-negative-dim-indexing
branch
from
bdd3861 to
97b7be0
Compare
This was referenced Jan 20, 2026
Closed
JakeHillion
pushed a commit
to JakeHillion/mlx
that referenced
this pull request
Jan 21, 2026
Co-authored-by: KD2YCU <me@kd2ycu.com> Co-authored-by: Awni Hannun <awni@apple.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Please include a description of the problem or feature this PR is addressing. If there is a corresponding issue, include the issue #.
array.h mixes signed and unsigned ints, causing potential issues #2993
Issue # 2993
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes