Jaccl refactor#3412
Merged
Merged
Conversation
adurham
pushed a commit
to adurham/mlx
that referenced
this pull request
Apr 19, 2026
This reverts commit 4400504.
1 task
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
a. Adds README and examples
b. Adds a NCCL style benchmark
a. We pay a small BW penalty and even smaller latency penalty but it does make things more predictable and stable. Eg people don't have to make sure that they always sample the same token or deal with diverging KV caches etc
all_gatherin the side-channel barrier to ensure no node can run ahead.armv8.6-aand chooses it at runtime if available, which results in much faster reduction for bf16.a. Specifically we now reach 12.2 GB/s algorithm bandwidth for bf16 up from ~9 GB/s for a 256 MB all reduce