Add barrier to JACCL#3459
Merged
Merged
Conversation
Contributor
Author
|
@zcbenz Can't tag you as a reviewer, can you please review when you get a chance? |
angeloskath
approved these changes
Apr 28, 2026
adurham
pushed a commit
to adurham/mlx
that referenced
this pull request
May 1, 2026
) Adds a barrier() op to JACCL distributed group plus minimal_barrier.cpp example. Useful for our 2-node TP setup where we sometimes need explicit sync points (e.g., post-allocation, pre-decode-step). Conflict resolution: 3 modify/delete on jaccl/lib/ files (README, examples CMakeLists, group.h). Upstream re-added them in ml-explore#3459; we apparently dropped lib/ at some prior point. Took theirs to get the new barrier infrastructure.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add barrier in JACCL as it is in NCCL
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes