Make step activation inclusive at the threshold#3694
Merged
Conversation
The documented behavior of `step` is to output 1 when `x >= threshold`, but the implementation used a strict `x > threshold`, so an input equal to the threshold (including the default threshold of 0) returned 0. Use a non-strict comparison to match the documented boundary and add a test.
tpegolotti
pushed a commit
that referenced
this pull request
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
stepactivation documents its boundary as inclusive:Both
nn.stepand thenn.Stepmodule render thisx >= thresholdform. The implementation, however, used a strict comparison:so an input exactly equal to the threshold returned
0instead of1. With the defaultthreshold=0this meansstep(0.0)evaluates to0, which contradicts the documented behavior.Switched to
x >= thresholdso the value at the boundary is included, matching the docstring. Added atest_stepcase covering the boundary for both the functional and module forms.