refactor(client): rename message handler callback#2596
Closed
MukundaKatta wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for the PR. Per our CONTRIBUTING.md we ask that PRs start from a linked, triaged issue with maintainer buy-in, which this one doesn't have yet. I'm closing this out as part of a backlog cleanup around the v2 release. Feel free to reopen if this is still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message_handlerparameters/fields tomessage_callbackfor consistency with the other callback optionsClientSession,Client,ClientSessionParameters, CLI wiring, tests, and migration docsCloses #2588
Testing
uv run ruff check src/mcp/client/client.py src/mcp/client/session.py src/mcp/client/session_group.py src/mcp/client/__main__.py tests/client/test_session.py tests/client/test_session_group.py tests/client/test_logging_callback.py tests/client/test_notification_response.py tests/experimental/tasks/client/test_handlers.py tests/experimental/tasks/server/test_server.py tests/server/mcpserver/test_integration.py tests/server/test_session.py tests/shared/test_progress_notifications.py tests/shared/test_session.py tests/shared/test_streamable_http.pyuv run ruff format --check src/mcp/client/client.py src/mcp/client/session.py src/mcp/client/session_group.py src/mcp/client/__main__.py tests/client/test_session.py tests/client/test_session_group.py tests/client/test_logging_callback.py tests/client/test_notification_response.py tests/experimental/tasks/client/test_handlers.py tests/experimental/tasks/server/test_server.py tests/server/mcpserver/test_integration.py tests/server/test_session.py tests/shared/test_progress_notifications.py tests/shared/test_session.py tests/shared/test_streamable_http.pyuv run pytest tests/client/test_logging_callback.py tests/client/test_notification_response.py tests/client/test_session.py tests/client/test_session_group.py tests/experimental/tasks/client/test_handlers.py tests/experimental/tasks/server/test_server.py tests/server/mcpserver/test_integration.py tests/server/test_session.py tests/shared/test_progress_notifications.py tests/shared/test_session.py tests/shared/test_streamable_http.py -q