-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Isolate the stdio server's stdin and stdout from handler subprocesses #3117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
fbe9841
Isolate the stdio server's stdin from handler subprocesses
maxisbey 2b0f3ac
Isolate the stdio server's stdout from handler code and subprocesses
maxisbey 2e609e1
Refuse abnormal processes instead of repairing them in stdio isolation
maxisbey 987b691
Replace dashes with plain punctuation in prose added by this branch
maxisbey 0ba79d4
Hold the stream claim for in-place fallbacks too
maxisbey 3e321f6
Add migration note for code that watches fd 0 directly
maxisbey 87dda97
Scope the fd 0 watchdog migration example to POSIX
maxisbey 6a6c544
Keep a still-diverted fd claimed when its restore fails
maxisbey 8a076d0
Roll forward when a failed claim cannot be rolled back
maxisbey a45283b
Reshape the stream claim into an explicit state machine
maxisbey cf0ba4f
Exclude POSIX-only fcntl lines from the Windows coverage gate
maxisbey 6990fa6
Open the errlog capture as UTF-8 in the noisy-child test
maxisbey 0f9695f
Never close a buffer the transport does not own
maxisbey ad9c115
Correct the watchdog poll mask note and use the public get_osfhandle
maxisbey 57271c2
Scope the stderr-closed isolation test to POSIX
maxisbey 885c6aa
Scope the stray-output docs to flushed writes
maxisbey 116a95f
Re-point fd at the wire when a divert dup2 fails
maxisbey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.