MOEN-46338: Support MoEngage iOS SDK 11.0.0 (Swift concurrency) - #101
MOEN-46338: Support MoEngage iOS SDK 11.0.0 (Swift concurrency)#101AnirudhaSM-engg-sdk wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🚪 Hodor is reviewing this PR... 👀 |
moe-hodor
Bot
added
branch:feature
![moe-hodor[bot]](https://cdn.github.com/in/3251438?s=60&v=4){kind=small}
|
|
||
| public static func getInfo(sdkInstance: MoEngageSDKInstance) -> MoEngageModule.Info { | ||
| return .init(name: "pluginBase", version: MoEngagePluginConstants.version) | ||
| public static func getInfo(sdkInstance: isolated MoEngageSDKInstance) -> MoEngageModule.Info? { |
There was a problem hiding this comment.
Let's return nil identity here to keep production behaviour of not sending the this module in integratedModules
There was a problem hiding this comment.
Done, getInfo now returns MoEngageModule.Info(identity: nil), keeping PluginBase out of the integratedModules payload
|
|
||
| ## Release Version | ||
|
|
||
| - [minor] MOEN-46338: Added support for the MoEngage iOS SDK 11.0.0 major release (Swift concurrency migration) |
There was a problem hiding this comment.
in public repo no need to mention ticket id. I doubt if it gets removed while releasing
There was a problem hiding this comment.
Removed, the release only strips the [minor]/[major] tag, not the ticket ID
| "name": "MoEngagePluginBase", | ||
| "postBuild": "Utilities/post_build.rb", | ||
| "sdkVerMin": "10.14.0", | ||
| "sdkVerMin": "11.00.0", |
There was a problem hiding this comment.
just cross check that with this change, plugin base version gets updated at release time
There was a problem hiding this comment.
Cross-checked, yes. The committed [major] Updated MoEngage-iOS-SDK line drives update_versions_and_changelogs to bump packages[0].version to major (6.10.0 → 7.0.0) at release, and the pluginBase-6.10.0 tag exists so the bump applies. update_sdk_dependency skips re-adding the SDK line (sdkVerMin is already 11.00.0), but the committed line preserves the major bump
3 participants
#Jira
https://moengagetrial.atlassian.net/browse/MOEN-46340
Changes
Adapts MoEngagePluginBase to the MoEngage iOS SDK 11.0.0 major release (Swift-6 / concurrency migration).
MoEngageNudgePosition→.top/.bottom/.bottomLeft/.bottomRight/.any/.none;MoEngageInAppActionType→.customAction/.navigationAction.MoEngageModule.Itemconformance updated to the SDK-11 actor-isolated protocol (isolatedMoEngageSDKInstance, optionalInfo, addedprocess(AsyncEvent) async+listensToAdditionalNotifications()).@MainActorand instantiated on the main actor (SDK'sMoEngageAuthenticationError.Listeneris now@MainActor).MoEngageInitialization→MoEngageConfig.FileBased(+asSdkConfig); PluginBase public API unchanged.apple-sdkSPM pin +sdkVerMinto 11.00.0; CHANGELOG entry ([minor]feature +[major]SDK line).Verification
Pending
## Release Versionplaceholder;[major]SDK line drives it).