Bug 2050411 - Handle null values in data without further recursion - #246
Merged
Conversation
Dexterp37
approved these changes
Jun 29, 2026
travis79
approved these changes
Jun 29, 2026
The newly introduced `session_sample_rate` can actually be reported as `null`. And `null` is an object. But it is not nested. Yet we recursed on it, eventually running out of memory. We now explicitly handle that and display it as `<null>` (just so we show something).
badboy
force-pushed
the
fix-rendering-with-null-values
branch
from
June 29, 2026 12:22
3e266f0 to
2f24bd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newly introduced
session_sample_ratecan actually be reported asnull.And
nullis an object. But it is not nested. Yet we recursed on it, eventually running out of memory.We now explicitly handle that and display it as
<null>(just so we show something).