[GoogleCode Issue 457] Push over git protocol hangs in msysGit

[childnode]

This is a resurrected issue from the old issue tracker ... still existing .. still annoying.

patch
0c499ea60f
marked to be cause of this push hangup as mentioned by johannes in comment#4

marked as "WontFix" at Apr 25, 2010 due to "nobody wants to fix" ;/
possible patch mentioned in comment#20 / comment#41

most details of problem analysys can be found in comment#35

File that needs patch nowadays (I think): https://github.com/msysgit/git/blob/master/send-pack.c

[dscho]

@childnode please feel free to take ownership of this issue and work towards its conclusion. In the links you referenced, there is a ton of information about the problem and the suggested ways to debug/fix.

[childnode]

I would, If I could do it.. unfortunatly my C skills are quite bad .. hacking and disabling the sideband would not solve the core problem and I expect you guys won't accept this patch, else you have had done this yourself in a minute, right?! ;)

[t-b]

Does anyone have a self-contained script (sh or batch) to reproduce the bug? This would be the obvious first step towards fixing the bug.

[dscho]

@childnode I understand. Unfortunately, the issue will need to wait, then, until somebody comes along driving the fix.

[dscho]

The issue can wait while being closed to protect my time (because it would otherwise see me, not @childnode, look at it every once in a while)

[slothbag]

I don't understand how this bug can be ignored for so long. Gits basic push functionality does not work even on the simplest of configurations.

I assume most people are hex editing the binary like me to make it work.

[t-b]

First step is still
#101 (comment) as not everyone encounters that bug.

Btw. hex editing binaries from FLOSS software sounds really awful.

[dscho]

@slothbag I guess it is not fixed at all because people like you make it work that way.

[cphillips83]

Using VMWare ESXi, running 2 machines with Win2k8. Install git on both machines from git-scm.com.

Machine A (open up port 9418, IP:10.0.0.220)
run cmd
mkdir c:\git\bareserver
cd c:\git\bareserver
git --bare init
git daemon --reuseaddr --base-path=C:\git --export-all --verbose --enable=receive-pack

Machine B (IP 10.0.0.225):
run cmd
mkdir C:\git
cd C:\git
git clone git://10.0.0.220/bareserver
cd bareserver
echo test >> readme.txt & git add . & git commit -m "test" & git push

Result:
[master 9447645] test
1 file changed, 1 insertion(+)
Counting objects: 20, done.
Compressing objects: 100% (12/12), done.
Writing objects: 100% (18/18)

Stuck sitting at writing objects, never completes (I have a few more objects from running this test a few times).

[cphillips83]

Leaving the above comment in tack as that was the original way I discovered the problem.

I was able to reproduce this on another box with a straight Win7 install using 1.8.5.2.msysgit.0 and the following batch file.

mkdir c:\git\hangserver
cd c:\git\hangserver
git --bare init
start cmd /c git daemon --reuseaddr --base-path=C:\git --export-all --verbose --enable=receive-pack

git clone git://localhost/hangserver hangclient
cd hangclient
echo test >> readme.txt & git add . & git commit -m "test" & git push

[cphillips83]

@t-b I have added a script above this comment that can reproduce it on a Win7 x64 machine (home premium) i5 2300 2.8ghz quad

[cphillips83]

I also see this in the task manager when running my script. Is this normal to have it launch 6 git.exes and 2 daemons?

I have killed all copies of this and ran the script again with the same result.

[cphillips83]

Not to keep spamming this thread, but I just came across something strange, while trying to attach the VS2012 debugger to all 6 git.exe at once, it finished properly (even tho it was already sitting there for 5+ minutes while I tried to investigate).

I can not consistently reproduce this. While attaching the debugger does have some sort of impact, VS2012 never successfully attached and when you end task devenv, the git push either fails or succeeds. I'm willing to put the time in to debug this as its a critical show stopper for me right now, but I have no idea where to start.

I'll update this comment periodically until someone comes along.

[t-b]

@cphillips83 Thanks! At last I can reproduce the problem.
Using your snippets from #101 (comment) I can reproduce the hanging on windows 7 x64.