Conversation
Instead of trying to derive it from the model file. In backends that specify HF url this results in a fragile logic. Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of trying to derive it from the model file. In backends that specify HF url this results in a fragile logic.
This pull request introduces a new
ModelPathfield to theModelOptionsmessage inbackend/backend.protoand updates the relevant code to utilize this new field. The changes ensure that theModelPathis used consistently across different parts of the codebase.Additions and Updates to Model Options:
backend/backend.proto: AddedModelPathfield to theModelOptionsmessage.Code Adjustments for New Field:
backend/python/diffusers/backend.py: UpdatedLoadModelmethod to useModelPathfor constructing theLoraAdapterpath instead ofModelFile.pkg/model/initializers.go: AddedModelPathto the gRPC options in thegrpcModelfunction.Notes for Reviewers
Signed commits