Validate host in google lyrics redirect allowlist - #659
Open
acts-1631 wants to merge 1 commit into
Open
Conversation
GoogleLyricsFetcher::isURLOk only tested whether the configured site keyword was a substring of the redirect URL, so a host such as justsomelyrics.com.attacker.com passed the check and the lyrics fetch followed the redirect to an attacker-controlled server. Because the google search is requested over plain HTTP, a MITM could substitute the redirect target and supply arbitrary lyrics content. Parse the URL host and require the keyword to be the whole host or a suffix preceded by a subdomain separator, defeating the substring bypass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GoogleLyricsFetcher::isURLOk only tested whether the configured site
keyword was a substring of the redirect URL, so a host such as
justsomelyrics.com.attacker.com passed the check and the lyrics fetch
followed the redirect to an attacker-controlled server. Because the
google search is requested over plain HTTP, a MITM could substitute the
redirect target and supply arbitrary lyrics content.
Parse the URL host and require the keyword to be the whole host or a
suffix preceded by a subdomain separator, defeating the substring
bypass.