select: computed: Fix lost unit in relative position offset derivation - #31
Closed
metan-ucw wants to merge 1 commit into
Closed
select: computed: Fix lost unit in relative position offset derivation#31metan-ucw wants to merge 1 commit into
metan-ucw wants to merge 1 commit into
Conversation
css_computed_{top,right,bottom,left} derive the used value of an
unspecified offset from the opposite side (§9.4.3, e.g. left = -right),
taking the unit from get_<side>_bits(style) >> 2. But get_<side>_bits
returns only the two type bits (bits & 0x3), so the >> 2 is always 0 and
the derived offset silently becomes CSS_UNIT_PX. A relatively positioned
box with `right: 1in` and auto left thus computed left as -1px instead of
-96px.
Read the opposite side's unit through its full accessor instead.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Cyril Hrubis <metan@ucw.cz>
Member
|
Thanks for reporting this issue. I confirmed it and spotted another issue with the handling of over-constrained This PR wouldn't compile due a bunch of I've fixed it in #33. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
css_computed_{top,right,bottom,left} derive the used value of an unspecified offset from the opposite side (§9.4.3, e.g. left = -right), taking the unit from get_bits(style) >> 2. But get_bits returns only the two type bits (bits & 0x3), so the >> 2 is always 0 and the derived offset silently becomes CSS_UNIT_PX. A relatively positioned box with
right: 1inand auto left thus computed left as -1px instead of -96px.Read the opposite side's unit through its full accessor instead.