select: fix counter-increment/reset dropping named counters - #34
Open
metan-ucw wants to merge 1 commit into
Open
select: fix counter-increment/reset dropping named counters#34metan-ucw wants to merge 1 commit into
metan-ucw wants to merge 1 commit into
Conversation
css__cascade_counter_increment_reset() builds the computed counter array in the COUNTER_INCREMENT_NAMED case but never sets `value` to CSS_COUNTER_INCREMENT_NAMED. `value` stays at its initial CSS_COUNTER_INCREMENT_INHERIT (0x0), so the named counters are handed to the property setter tagged as INHERIT and discarded — computed counter-increment/counter-reset always read back as none/inherit. The helper is shared, so both counter-increment and counter-reset were affected. Set value = CSS_COUNTER_INCREMENT_NAMED once counters are read. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Cyril Hrubis <metan@ucw.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
css__cascade_counter_increment_reset() builds the computed counter array in the COUNTER_INCREMENT_NAMED case but never sets
valueto CSS_COUNTER_INCREMENT_NAMED.valuestays at its initial CSS_COUNTER_INCREMENT_INHERIT (0x0), so the named counters are handed to the property setter tagged as INHERIT and discarded — computed counter-increment/counter-reset always read back as none/inherit.The helper is shared, so both counter-increment and counter-reset were affected. Set value = CSS_COUNTER_INCREMENT_NAMED once counters are read.