netteForms.js: Set validation result CSS classes#64
Open
hranicka wants to merge 2 commits into
Open
Conversation
Contributor
|
I like it. Best part is you've essentialy created hooks that can be overriden with custom functions. |
Contributor
There was a problem hiding this comment.
Should have nette namespace.
dg
force-pushed
the
master
branch
2 times, most recently
from
May 21, 2015 11:49
131f7d2 to
532059a
Compare
Contributor
Author
|
This PR should be without any BC break. Adds CSS classes according to validation result of each control. Classes are prefixed with Functions can be overridden with custom ones ( So with this, on target system we can easily style valid/invalid form controls or add custom code executed for validation results. |
dg
force-pushed
the
master
branch
2 times, most recently
from
June 19, 2015 12:05
a57a557 to
55d0eb8
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
April 5, 2016 23:23
9e359e6 to
fa84d63
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
April 11, 2016 01:44
3c1619a to
31bc0a3
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
April 21, 2016 13:03
6b04b51 to
d1c30d6
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
May 19, 2016 00:28
fd381fb to
b70e5da
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
June 1, 2016 18:14
c996b4c to
c8f4f95
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
July 9, 2016 12:02
27d3e69 to
57295d1
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
January 4, 2017 14:16
5f19501 to
105a1af
Compare
dg
force-pushed
the
master
branch
14 times, most recently
from
January 30, 2017 00:54
a6ec22a to
c2c4dc3
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
February 2, 2017 03:03
454e643 to
a8c2e65
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
March 29, 2017 16:48
571b36c to
841e5de
Compare
Member
dg
force-pushed
the
master
branch
4 times, most recently
from
July 14, 2017 10:58
8ed13d7 to
d6aa86e
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
July 24, 2017 13:52
ebfaab8 to
6a0c2b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it's useful visually distinguish valid/invalid inputs.
We use something like the code in this PR.
When we need to use another CSS classes or something absolutely different, it's possible redefine
Nette.markControlValidandNette.markControlInvalid.But I don't know if the PR should be accepted.
Also without it we can redefine
Nette.validateControl, call original backed-up function and handle the result.So most likely this will be closed without merge.
But I can try it and listen your opinions.