Skip to content

Code review feedback#63

Merged
lvrfrc87 merged 38 commits into
developfrom
lvrfrc87
Jun 22, 2022
Merged

Code review feedback#63
lvrfrc87 merged 38 commits into
developfrom
lvrfrc87

Conversation

@lvrfrc87

Copy link
Copy Markdown
Collaborator

Close #62

@lvrfrc87 lvrfrc87 self-assigned this May 24, 2022
@lvrfrc87
lvrfrc87 marked this pull request as draft May 24, 2022 08:02
scetron
scetron previously approved these changes May 25, 2022
Comment thread netcompare/check_types.py Outdated
Comment thread netcompare/check_types.py Outdated
Comment thread netcompare/check_types.py Outdated
Comment thread netcompare/check_types.py
Comment thread netcompare/check_types.py Outdated
Comment thread netcompare/operator.py Outdated
Comment thread netcompare/operator.py Outdated
Comment thread netcompare/utils/data_normalization.py Outdated
Comment thread netcompare/utils/jmespath_parsers.py Outdated
Comment thread netcompare/utils/jmespath_parsers.py Outdated
lvrfrc87 and others added 10 commits June 14, 2022 09:36
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
glennmatthews
glennmatthews previously approved these changes Jun 15, 2022

@glennmatthews glennmatthews left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

glennmatthews
glennmatthews previously approved these changes Jun 22, 2022
@lvrfrc87
lvrfrc87 marked this pull request as ready for review June 22, 2022 13:02
@lvrfrc87
lvrfrc87 merged commit 5a893b5 into develop Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code review feedback

5 participants