Skip to content

Fix 67 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lvrfrc87 merged 8 commits into from
Jul 25, 2022
Merged

Fix 67 #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4443a22
add tests for issue 67
lvrfrc87 Jul 21, 2022
338030c
FIx 67
lvrfrc87 Jul 21, 2022
41d8477
raise error if JMSPath retunrs None
lvrfrc87 Jul 25, 2022
c04f5b9
fix tests
lvrfrc87 Jul 25, 2022
85c782e
rename test file and function
lvrfrc87 Jul 25, 2022
a3762da
Update tests/test_get_value.py
lvrfrc87 Jul 25, 2022
2ed2f1e
Update tests/test_get_value.py
lvrfrc87 Jul 25, 2022
58e82a5
Update tests/test_get_value.py
lvrfrc87 Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions netcompare/check_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ def get_value(output: Union[Mapping, List], path: str = "*", exclude: List = Non

values = jmespath.search(jmespath_value_parser(path), output)

if values is None:
raise TypeError("JMSPath returned 'None'. Please, verify your JMSPath regex.")

# check for multi-nested lists if not found return here
if not any(isinstance(i, list) for i in values):
return values
Expand Down
17 changes: 17 additions & 0 deletions tests/test_get_value.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
"""Test GitHub issues."""
import pytest
from netcompare import CheckType


my_data = [{"global": {"peers": {"10.1.0.0": "peer1", "10.2.0.0": "peer2"}}}]


@pytest.mark.parametrize("data", my_data)
def test_jmspath_return_none(data):
"""Handle exception when JMSPath retunr None."""
my_jmspath = "global[*]"
my_check = CheckType.init(check_type="exact_match")
with pytest.raises(TypeError) as error:
my_check.get_value(output=data, path=my_jmspath)() # pylint: disable=E0110

assert "JMSPath returned 'None'. Please, verify your JMSPath regex." in error.value.__str__()