fix: ensure password is used for axios request - #1172
Merged
Conversation
nfebe
approved these changes
Oct 16, 2025
artonge
approved these changes
Oct 16, 2025
artonge
left a comment
artonge
left a comment
Collaborator
There was a problem hiding this comment.
Looks ok.
Not sure how it was working before... 🤔
Collaborator
Author
I think it was not its something only broken in v6 |
Before this the promise of `spawnDialog` was awaited so it never resolved, because the dialog did not close until axios succeeded. And axios only continued when the dialog was closed... Instead add a module scope variable to keep track of an already open password confirmation dialog and reuse it if the password is invalid. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
st3iny
approved these changes
Oct 16, 2025
Collaborator
Author
|
(before merge I test this in server right now) |
susnux
force-pushed
the
fix/confirm-password
branch
from
October 16, 2025 11:53
e7e018a to
0e9a6ec
Compare
Collaborator
Author
|
Squashed the commits - tested locally with server and works fine ✅ |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this the promise of
spawnDialogwas awaited so it never resolved, because the dialog did not close until axios succeeded. And axios only continued when the dialog was closed...Instead add a module scope variable to keep track of an already open password confirmation dialog and reuse it if the password is invalid.