fix: imports from emoji-mart-vue-fast - #2521
Merged
Merged
Conversation
No need to import from src. These are exported fine in the dist. Importing from src also caused issues in jest tests in the text app as they do not transform the src import: https://github.com/nextcloud/text/runs/5315732664?check_suite_focus=true#step:7:85 Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
requested review from
a team,
PVince81,
artonge,
mejo- and
skjnldsv
and removed request for
a team
February 24, 2022 08:15
skjnldsv
approved these changes
Feb 24, 2022
szaimen
approved these changes
Feb 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to import from src. These are exported fine in the dist.
Importing from src also caused issues in jest tests in the text app
as they do not transform the src import:
https://github.com/nextcloud/text/runs/5315732664?check_suite_focus=true#step:7:85