V6.0.0 beta.2 - #3008
Merged
Merged
Conversation
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
requested review from
juliusknorr,
nickvergessen,
raimund-schluessler and
skjnldsv
August 11, 2022 20:10
Contributor
|
See my comment in #3006 (comment). |
Contributor
Author
|
alright, thanks for the comment. |
Contributor
It should work pretty much the same as for the standalone trigger button, with the difference that the default-icon class should only be set if the icon slot of Actions is empty, and that in that case the icon slot of the button must not be populated. |
Contributor
Author
|
see #3006 (comment) as it seems to be working already |
PVince81
added
2. developing
Contributor
Author
|
as discussed, need to add back default-icon support as well for Actions |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
PVince81
added
3. to review
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Contributor
Author
|
updated changelog, please review! |
PVince81
marked this pull request as ready for review
August 12, 2022 09:07
raimund-schluessler
approved these changes
Aug 12, 2022
skjnldsv
approved these changes
Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contains #3006 which moves #2911 from "breaking" to "enhancement".
note: the regressions were just a misunderstanding about whether we wanted to keep or break icon attr: #3006 (comment)