Action and popovermenu accessibility - #342
Merged
Merged
Conversation
skjnldsv
added
3. to review
skjnldsv
requested review from
ChristophWurst,
jancborchardt,
juliusknorr and
korelstar
April 9, 2019 16:59
skjnldsv
force-pushed
the
fix/action/popover-mouse-design
branch
from
April 9, 2019 17:07
e381d5c to
8f55a06
Compare
skjnldsv
commented
Apr 9, 2019
| @keydown.down.exact.prevent="focusNextAction" | ||
| @keydown.shift.tab.prevent="focusPreviousAction" | ||
| @keydown.tab.exact.prevent="focusNextAction" | ||
| @keydown.page-up.exact.prevent="focusFirstAction" |
Contributor
Author
There was a problem hiding this comment.
oh man, this is so good!! 🌟
skjnldsv
added
2. developing
skjnldsv
commented
Apr 9, 2019
skjnldsv
force-pushed
the
fix/action/popover-mouse-design
branch
from
April 9, 2019 17:38
84fd1de to
b2ff781
Compare
Contributor
|
Nice nice!
What do you mean by that?
Why that? "-1" means they would be taken out of the tab order, which should be avoided. (Ideally there is no tabindex needed at all, because the HTML elements and order should be accessible.) |
Contributor
Author
|
@jancborchardt read the aria docs :p
|
ChristophWurst
approved these changes
Apr 11, 2019
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/action/popover-mouse-design
branch
from
April 11, 2019 12:01
b2ff781 to
8a714a0
Compare
skjnldsv
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See aria guidelines https://www.w3.org/TR/2016/WD-wai-aria-practices-1.1-20161214/examples/menu-button/menu-button-1/menu-button-1.html
Added:
Missing?
tabindex="-1"on all menu items@nextcloud/accessibility @nextcloud/vue thoughts and reviews? ❤️