Skip to content

AppSidebar. fix error when no tabs - #359

Merged
skjnldsv merged 1 commit into
masterfrom
fix-sidebar-tabs
Apr 20, 2019
Merged

AppSidebar. fix error when no tabs#359
skjnldsv merged 1 commit into
masterfrom
fix-sidebar-tabs

Conversation

@korelstar

Copy link
Copy Markdown
Contributor

There was an error when a AppSidebar doesn't contain any AppSidebarTabs and uses just the content directly.

See #340 (comment)

@korelstar korelstar added bug Something isn't working 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels Apr 19, 2019
@korelstar korelstar added this to the next milestone Apr 19, 2019
@korelstar
korelstar requested a review from skjnldsv April 19, 2019 17:31

@skjnldsv skjnldsv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥰

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 20, 2019
@skjnldsv
skjnldsv merged commit 9925674 into master Apr 20, 2019
@skjnldsv
skjnldsv deleted the fix-sidebar-tabs branch April 20, 2019 08:12
@skjnldsv skjnldsv modified the milestones: next, 0.11.0 May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: app-sidebar Related to the app-sidebar component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants