enh(NcActions): Navigation link actions - #4084
Merged
Merged
Conversation
Pytal
added
3. to review
12 tasks
Contributor
Author
|
/backport to stable7 |
skjnldsv
reviewed
May 11, 2023
JuliaKirschenheuter
approved these changes
May 11, 2023
Pytal
force-pushed
the
enh/a11y-nav-actions
branch
from
May 12, 2023 01:23
4bbf94e to
1da987e
Compare
JuliaKirschenheuter
approved these changes
May 12, 2023
Contributor
|
I haven't realized that would look that complex 🙈 |
Contributor
Author
Either way is fine with me, just the initial reason for not detecting it automatically in the first place was that the overhead didn't seem worth it Let me know which way you'd think is best and I'll update as needed :) |
Contributor
Author
|
Which one do you think is best @skjnldsv? |
Contributor
I don't know. |
artonge
approved these changes
May 25, 2023
artonge
left a comment
artonge
left a comment
Contributor
There was a problem hiding this comment.
Auto-detecting looks ok to me.
I would add a comment, though.
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
enh/a11y-nav-actions
branch
from
May 25, 2023 16:43
1da987e to
ff5ad4b
Compare
Pytal
added
4. to release
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically remove attributes that are incompatible with accessible navigation when all action links are website navigation links
References