Stop propagation of keyboard navigation in a number of components - #4501
Merged
Conversation
ShGKme
requested review from
JuliaKirschenheuter,
Pytal,
raimund-schluessler,
skjnldsv,
susnux and
szaimen
September 6, 2023 14:17
ShGKme
marked this pull request as ready for review
September 6, 2023 14:20
skjnldsv
approved these changes
Sep 6, 2023
szaimen
removed their request for review
September 6, 2023 15:29
Pytal
suggested changes
Sep 6, 2023
GretaD
approved these changes
Sep 7, 2023
Contributor
|
you can Dissmiss changes requested by pytal, if its delivered and they dont review it on time |
Pytal
approved these changes
Sep 7, 2023
ShGKme
force-pushed
the
fix/stop-keyboard-navigation
branch
from
September 7, 2023 15:43
4c7ebb4 to
da9582d
Compare
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/stop-keyboard-navigation
branch
from
September 7, 2023 15:56
da9582d to
2cb60f2
Compare
Contributor
Author
|
Rebased onto master with fixtup, no other changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
#4406 was merged too early, it solved only problems with Arrows in general, but not ESC.
Arrows and ESC are used for keyboard navigation in some components. But the keydown event is not stopped. As a result, arrows and ESC not only manipulate such components but also are handled globally.
For example:
NcModal:NcModalshould only close popover, but also close the ModalNcModalTo test add a global event listener and check console:
🖼️ Screenshots
🚧 Tasks
NcModal.stopmodifier:NcAppSidebarnameEditableNcAppSidebarTabsNcInputConfirmCancelNcSelect: add interceptor viamapKeydownto stop propagation when select is openNcPopover: manually add keydown event listener similar to how focus trap is added. It can be cleaner with an additional wrapper of popover contentNcPopover:NcActionsNcEmojiPickerNcUserBubbleNcColorPickerNcDatetimePickerIgnored:
NcHeaderMenu:NcListItem:Additional discussion
Both this PR and #4406 fixes Arrows navigation in Sidebar tabs being in a modal viewer. But they do it in a different way:
NcModalfrom switching slides by any not stopped arrows outside the modalI'd keep both PRs but we can revert #4406.
For example, if we want to switch slides in Viewer when the focus is on Tab panel content div.
🏁 Checklist