Skip to content

fix: re-export NcEllipsisedOption and NcInputField in root export - #5666

Merged
ShGKme merged 2 commits into
masterfrom
chore/re-export-nc-ellipsised-option
Jun 4, 2024
Merged

fix: re-export NcEllipsisedOption and NcInputField in root export#5666
ShGKme merged 2 commits into
masterfrom
chore/re-export-nc-ellipsised-option

Conversation

@ShGKme

@ShGKme ShGKme commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

Both components were not only documented and available in a direct import @nextcloud/vue/dist/Components/* but also used in apps already.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added 3. to review Waiting for reviews feature: input-field Covering the InputField, TextField, ... feature: ellipsised-option labels Jun 4, 2024
@ShGKme ShGKme added this to the 8.12.1 milestone Jun 4, 2024
@ShGKme ShGKme self-assigned this Jun 4, 2024
@ShGKme

ShGKme commented Jun 4, 2024

Copy link
Copy Markdown
Contributor Author

/backport to next

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@ChristophWurst

Copy link
Copy Markdown
Contributor

nit: the patch changes the exports of the library so semantically it's a feat or fix 🤓

@ShGKme ShGKme added the bug Something isn't working label Jun 4, 2024
@ShGKme ShGKme changed the title chore: re-export NcEllipsisedOption and NcInputField in root export fix: re-export NcEllipsisedOption and NcInputField in root export Jun 4, 2024
ShGKme added 2 commits June 4, 2024 19:18
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
ShGKme force-pushed the chore/re-export-nc-ellipsised-option branch from c167fcb to 2fe66e8 Compare June 4, 2024 17:18
@ShGKme

ShGKme commented Jun 4, 2024

Copy link
Copy Markdown
Contributor Author

nit: the patch changes the exports of the library so semantically it's a feat or fix 🤓

Renamed to fix. Not a new feature, because these components were already exported directly.

@ShGKme
ShGKme enabled auto-merge June 4, 2024 17:19
@ShGKme
ShGKme merged commit f0e4e75 into master Jun 4, 2024
@ShGKme
ShGKme deleted the chore/re-export-nc-ellipsised-option branch June 4, 2024 17:20
@backportbot

backportbot Bot commented Jun 4, 2024

Copy link
Copy Markdown

The backport to next failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout next
git pull origin next

# Create the new backport branch
git checkout -b backport/5666/next

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick eebde479 2fe66e8d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5666/next

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request bug Something isn't working feature: ellipsised-option feature: input-field Covering the InputField, TextField, ...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants