fix(richText): do not handle relative links without leading slash as router links - #5703
Merged
susnux merged 1 commit intoJun 13, 2024
Conversation
ShGKme
added
bug
ShGKme
force-pushed
the
fix/autolink--support-non-http-scheme-and-no-trailing-slash
branch
2 times, most recently
from
June 13, 2024 14:56
3c3e641 to
d43acf1
Compare
susnux
reviewed
Jun 13, 2024
ShGKme
changed the title
susnux
reviewed
Jun 13, 2024
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/autolink--support-non-http-scheme-and-no-trailing-slash
branch
from
June 13, 2024 15:28
d43acf1 to
752fa36
Compare
susnux
approved these changes
Jun 13, 2024
nickvergessen
approved these changes
Jun 13, 2024
nickvergessen
left a comment
nickvergessen
left a comment
Contributor
There was a problem hiding this comment.
Looks like it should fix it, but didn't test
susnux
deleted the
fix/autolink--support-non-http-scheme-and-no-trailing-slash
branch
June 13, 2024 15:33
Contributor
|
/backport to next |
Merged
2 tasks
4 tasks
This was referenced Aug 9, 2024
This was referenced Aug 19, 2024
This was referenced Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
autolinksupports relative URLs, for example,/call/ab34cdis resolved as a Talk route.https?://.call/abcormailto:email@nextcloud.ltdalso doesn't start with HTTP././is enough for explicitly adding a check for non-http schemes.VueRouter handles such URLs according to the URL RFC, for example, being on
/call/abcpage, a linkdefis resolved as/call/defrelative to/call/. We don't want to support such links anyway, so relative URL MUST start with a slash.Alternative solution: add a leading slash
/to relative links.🚧 Tasks
/.🏁 Checklist
nextrequested with a Vue 3 upgrade