feat(NcAppSidebar): force show navigation for a single tab - #5740
Merged
Conversation
Antreesy
added
enhancement
ShGKme
reviewed
Jun 27, 2024
Contributor
I'd say, it is fine. Yes, it doesn't make much sense to have tab navigation with one tab, but from a11y perspective it is still "active tab one of one" |
ShGKme
approved these changes
Jun 28, 2024
susnux
reviewed
Jun 28, 2024
susnux
approved these changes
Jun 28, 2024
susnux
left a comment
susnux
left a comment
Contributor
There was a problem hiding this comment.
Makes sense, just one comment about the prop naming but no blocker as I am fine with both if you agree.
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
feat/noid/force-sidebar-navigation
branch
from
June 29, 2024 06:48
1df8d31 to
e34ca2c
Compare
Contributor
|
/backport to next |
This was referenced Aug 9, 2024
This was referenced Aug 19, 2024
This was referenced Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
nextrequested with a Vue 3 upgrade