fix(NcDialog): Ensure the dialog is correctly labelled by its name - #5771
Merged
Conversation
susnux
added
bug
Contributor
Author
|
/backport to next |
* Added `labelId` prop to NcModal to allow label modal without a name * Pass the navigation id (the ID of the headline element of NcDialog) to `labelId` * Added cypress tests Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Antreesy
approved these changes
Jul 4, 2024
Antreesy
left a comment
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Changes and tests look good!
skjnldsv
approved these changes
Jul 4, 2024
2 tasks
This was referenced Aug 9, 2024
This was referenced Aug 19, 2024
This was referenced Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
labelIdprop to NcModal to allow label modal without a namelabelId🏁 Checklist
nextrequested with a Vue 3 upgrade