fix(NcListItem): Anchor height was set not to content but random area - #5780
Merged
Conversation
* The anchor height is in reality not default-clickable-area but 2 lines of text * Fix visual regressions on Nextcloud 30 by making the padding dependant of the border radius * The margin for the focus-visual needs only to account for the box shadow on the first and last element, all other can just have a margin for the border. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
bug
marcoambrosini
approved these changes
Jul 18, 2024
This was referenced Jul 18, 2024
Antreesy
approved these changes
Jul 18, 2024
Contributor
Author
|
/backport to next |
This was referenced Aug 14, 2024
This was referenced Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
@marcoambrosini this is a bug fix for invalid height which causes some errors, but maybe it also fixes visual regression good enough for Nextcloud 30, what do you think?
See screencase for Nextcloud 30 and 29 behavior below
🖼️ Screenshots
Bildschirmaufnahme_20240704_175824.webm
🏁 Checklist
nextrequested with a Vue 3 upgrade