Skip to content

fix(NcListItem): do not render counter on falsy values - #5834

Merged
susnux merged 1 commit into
masterfrom
fix/noid/nclistitem-counter-null
Jul 18, 2024
Merged

fix(NcListItem): do not render counter on falsy values#5834
susnux merged 1 commit into
masterfrom
fix/noid/nclistitem-counter-null

Conversation

@Antreesy

@Antreesy Antreesy commented Jul 18, 2024

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Fix empty container, if counter has been passed as falsy value, but not 0 (null)

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: list-item Related to the list-item component labels Jul 18, 2024
@Antreesy Antreesy added this to the 8.14.1 milestone Jul 18, 2024
@Antreesy
Antreesy requested review from Pytal, ShGKme and susnux July 18, 2024 19:23
@Antreesy Antreesy self-assigned this Jul 18, 2024
@Antreesy

Copy link
Copy Markdown
Contributor Author

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: list-item Related to the list-item component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants