fix(NcChip): Ensure chips without icon do not reserve empty space for icon - #5859
Merged
Conversation
susnux
added
bug
Contributor
Author
|
/backport to next |
susnux
force-pushed
the
fix/nc-chip-without-icon
branch
from
July 23, 2024 22:54
97e1b4f to
187fd71
Compare
ShGKme
reviewed
Jul 24, 2024
ShGKme
reviewed
Jul 24, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
ShGKme
approved these changes
Jul 29, 2024
susnux
force-pushed
the
fix/nc-chip-without-icon
branch
from
July 29, 2024 07:17
187fd71 to
cb04cae
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/nc-chip-without-icon
branch
from
July 29, 2024 07:19
cb04cae to
eae6105
Compare
Merged
2 tasks
This was referenced Aug 19, 2024
This was referenced Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
If there is no icon then there should be no empty space.
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade