fix(NcSelect): Ensure component height is same as input element - #5883
Merged
Conversation
…r NcSelect with users Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
bug
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/nc-select-size
branch
from
July 29, 2024 14:13
e56c883 to
ca340e4
Compare
This was referenced Jul 29, 2024
Contributor
|
Is it supposed to be |
Contributor
Author
Where do you see that number? It should be always |
Contributor
Ok yeah my bad, tested it on 30 and looks good. But we will have to update some styling in calendar @ChristophWurst as it breaks |
GVodyanov
approved these changes
Aug 1, 2024
marcoambrosini
approved these changes
Aug 1, 2024
Contributor
Author
|
/backport to next |
2 tasks
Merged
Contributor
|
Seem now to become an issue on 28/29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Currently the element was 36px instead of 34px which looks weird if using multiple input elements side by side (caused by search input being 34px + 2px border).
Also there was jumping because there are two different border width, so we need to adjust the input height based on the outer border width and the margin of the selected options.
🏁 Checklist
nextrequested with a Vue 3 upgrade